Skip to content

Fix variable names in 'Viewing Type Information' article #24102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Fix variable names in 'Viewing Type Information' article #24102

merged 1 commit into from
May 10, 2021

Conversation

TheBlueSky
Copy link
Contributor

Summary

Fix variable names in Viewing Type Information article.

Fixes #23868

@TheBlueSky TheBlueSky requested review from BillWagner, IEvangelist and a team as code owners May 8, 2021 11:15
@dotnet-bot dotnet-bot added this to the May 2021 milestone May 8, 2021
adegeo
adegeo approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on! Approved.

Team, note the snippets build failure. Since this is updating an old article with just changing the variable names, I think it's OK to pass this through as it's not changing code flow or logic.

@adegeo adegeo closed this May 10, 2021
@adegeo adegeo reopened this May 10, 2021
@adegeo adegeo merged commit 5beded2 into dotnet:main May 10, 2021
@TheBlueSky TheBlueSky deleted the fix-variablenames branch May 11, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adegeo adegeo adegeo approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner BillWagner is a code owner

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

About sample code variable style problem
3 participants
@TheBlueSky @adegeo @dotnet-bot