-
Notifications
You must be signed in to change notification settings - Fork 6k
promote the standard in TOC #24974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote the standard in TOC #24974
Conversation
/cc @DamianEdwards |
That's where they are now. Would a better fix be updating the breadcrumbs to match the new TOC? |
@BillWagner sorry I'm still not quite following. This is what I see: Those three nodes are all at the same level in the TOC. |
- update the breadcrumb config - add "specifications" parent node.
@DamianEdwards Take a look now. I did a bit of rearranging. I could also add another level under these nodes as well: |
@Youssef1313 This is another false positive on the build verifier. A child TOC (or 2 actually) were removed. These don't need any redirections. |
@BillWagner Is this specific to |
This only applies to any toc.yml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new structure looks good, makes sense to me. One nit: the TOC is out of sync with the text of some docs, e.g. C# 9 Records intro text calls it a "proposal" that "tracks the specification", while the TOC identifies it as a specification.
Many of the feature proposals aren't labeled internally as a "specification".
closing and reopening for lint to be run |
|
Fixes #24959
Internal preview link