Skip to content

promote the standard in TOC #24974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2021
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Jul 2, 2021

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 2, 2021
@BillWagner BillWagner requested a review from tdykstra July 2, 2021 19:45
@BillWagner
Copy link
Member Author

/cc @DamianEdwards

@DamianEdwards
Copy link
Member

Could we actually nest those two nodes under the "Language reference" node? That seems to be how the structure is intended as clicking on one shows "Language reference" as the parent in breadcrumbs:
image

@BillWagner
Copy link
Member Author

@DamianEdwards

Could we actually nest those two nodes under the "Language reference" node?

That's where they are now. Would a better fix be updating the breadcrumbs to match the new TOC?

@DamianEdwards
Copy link
Member

@BillWagner sorry I'm still not quite following. This is what I see:
image

Those three nodes are all at the same level in the TOC.

- update the breadcrumb config
- add "specifications" parent node.
@BillWagner BillWagner requested a review from a team as a code owner July 2, 2021 20:43
@BillWagner
Copy link
Member Author

@DamianEdwards Take a look now. I did a bit of rearranging.

I could also add another level under these nodes as well:

Screen Shot 2021-07-02 at 4 48 17 PM

@BillWagner BillWagner marked this pull request as draft July 2, 2021 20:56
@BillWagner
Copy link
Member Author

BillWagner commented Jul 2, 2021

@Youssef1313 This is another false positive on the build verifier.

A child TOC (or 2 actually) were removed. These don't need any redirections.

@BillWagner BillWagner marked this pull request as ready for review July 2, 2021 21:43
@Youssef1313
Copy link
Member

@BillWagner Is this specific to toc.yml only (ie, other yml files will need redirection)?

@BillWagner
Copy link
Member Author

@Youssef1313

Is this specific to toc.yml only (ie, other yml files will need redirection)?

This only applies to any toc.yml file.

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new structure looks good, makes sense to me. One nit: the TOC is out of sync with the text of some docs, e.g. C# 9 Records intro text calls it a "proposal" that "tracks the specification", while the TOC identifies it as a specification.

Many of the feature proposals aren't labeled internally as a "specification".
@BillWagner BillWagner enabled auto-merge (squash) July 6, 2021 17:00
@BillWagner BillWagner disabled auto-merge July 6, 2021 17:00
@BillWagner
Copy link
Member Author

closing and reopening for lint to be run

@adegeo
Copy link
Contributor

adegeo commented Jul 6, 2021

Should these be ordered descending? I would think we want the latest version at the top. I realized I was talking about the breadcrumb which isn't really ordered.. ha!

@BillWagner BillWagner enabled auto-merge (squash) July 6, 2021 18:11
@BillWagner BillWagner disabled auto-merge July 6, 2021 18:12
@BillWagner BillWagner merged commit f4489ec into dotnet:main Jul 6, 2021
@BillWagner BillWagner deleted the promote-spec-in-toc branch July 6, 2021 18:12
@BillWagner BillWagner added the okr-curation OKR: Curate content to remove outdated recommendations label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-csharp/svc lang-reference/subsvc okr-curation OKR: Curate content to remove outdated recommendations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote ECMA spec documents in TOC
6 participants