Skip to content

Use MSTest 3.9.3 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use MSTest 3.9.3 #850

wants to merge 1 commit into from

Conversation

Evangelink
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 23, 2025 14:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MSTest package version to 3.9.3 across multiple test projects and aligns assertion methods with the new MSTest best practices. Key changes include:

  • Replacing separate MSTest packages with the consolidated MSTest package.
  • Switching from Assert.ThrowsException to Assert.ThrowsExactly for stricter exception verification.
  • Adjusting the argument order in Assert.AreEqual calls to pass the expected value first.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Ordering.UnitTests/Ordering.UnitTests.csproj Removed deprecated MSTest package references and added the consolidated MSTest package.
tests/Ordering.UnitTests/Domain/OrderAggregateTest.cs Updated exception assertions and corrected parameter order in Assert.AreEqual calls.
tests/Ordering.UnitTests/Domain/BuyerAggregateTest.cs Updated exception assertions to use Assert.ThrowsExactly.
tests/Ordering.UnitTests/Application/NewOrderCommandHandlerTest.cs Updated exception assertions to use Assert.ThrowsExactly.
tests/ClientApp.UnitTests/ViewModels/MockViewModelTests.cs Adjusted assertion argument order to match best practices.
tests/ClientApp.UnitTests/ViewModels/CatalogViewModelTests.cs Revised assessment of collection Count to prioritize expected count first.
tests/ClientApp.UnitTests/Services/OrdersServiceTests.cs Revised Count assertion order in service tests.
tests/ClientApp.UnitTests/Services/CatalogServiceTests.cs Revised Count assertion order in service tests.
tests/ClientApp.UnitTests/Services/BasketServiceTests.cs Revised Count assertion order in service tests.
tests/ClientApp.UnitTests/ClientApp.UnitTests.csproj Removed MSTest.TestAdapter and MSTest.TestFramework and added MSTest 3.9.3.
tests/Basket.UnitTests/BasketServiceTests.cs Revised collection assertion for basket items.
tests/Basket.UnitTests/Basket.UnitTests.csproj Removed deprecated MSTest package references and added the consolidated MSTest package.
Directory.Packages.props Updated MSTest package version and bumped the Microsoft.NET.Test.Sdk version.

@Evangelink
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 850 in repo dotnet/eShop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant