Change analyzer references to use the standard/recommended form #34596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hitting some build issues related to EFDiagnostics - a static class of constants that lives inside EFCore.Analyzers and used from the our projects. Interestingly, the EFCore projects references EFCore.Analyzers with
PrivateAssets="contentfiles;build"; the other projects (Relational, Cosmos...) reference it withReferenceOutputAssembly="False" OutputItemType="Analyzer"- which is the proper way to refer to analyzers (docs). It seems like only the EFCore dependency on EFCore.Analyzers allows using EFDiagnostics - if I change it to also useReferenceOutputAssembly="False" OutputItemType="Analyzer", I'm no longer able to use EFDiagnostics.This PR changes things to work in the standard/recommend way: only
ReferenceOutputAssembly="False" OutputItemType="Analyzer"is used to reference EFCore.Analyzers, and EFDiagnostics is moved to Shared.