-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[9.0] Update CI OSes #115503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] Update CI OSes #115503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI configuration to refresh the list of OS images used in the Helix queues setup, aligning with recent changes in supported OS versions.
- Removed outdated or restructured OS images
- Added new OS definitions (e.g., AzureLinux.3.0)
- Reordered some image entries for clarity
Comments suppressed due to low confidence (2)
eng/pipelines/libraries/helix-queues-setup.yml:56
- [nitpick] The new AzureLinux entry uses 'Ubuntu.2204.Amd64.open' with lowercase 'open' in the tag, which differs from other entries that use 'Open'. Consider standardizing the casing for consistency and clarity.
- (AzureLinux.3.0.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64
eng/pipelines/libraries/helix-queues-setup.yml:66
- [nitpick] The re-introduction of the Centos.9 entry here may require verification against the previously removed entry. Confirm that this change is intentional and that it correctly reflects the supported Centos-stream version.
- (Centos.9.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:centos-stream9-helix
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
These issues all look existing. |
I initially moved the Alpine build to Alpine 3.22, which pulls in LLVM 20. Lots of breaks. We made a bunch of changes for LLVM 20 in main that don't exist in this branch. We want to avoid doing that. That just means we'll never be able to move this branch to use
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like everything but |
runtime-extra-platforms linux_musl-x64 Release Libraries_Release_CoreCLR failure looks related.
|
Yes. I changed the condition for Linux-musl and it became inconsistent with some higher-level part of the build. The old model was to test old and new Alpine versions. I don't think we need to do that. Newest is good enough. If we start seeing customer-reported regressions on Alpine 3.19 when we're only testing Alpine 3.22, then we can bring back the old model. I don't think that will happen. The thing with Alpine is that the vast majority of our users are going to come from the |
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Mariner 2.0 was in the wrong place. It needs to be in a place where a single line can be deleted as the total change when we remove it for EOL. |
/azp run runtime-libraries-coreclr outerloop-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries-coreclr outerloop-linux |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
There is one extra platforms failure for Linux in scope to consider, on Ubuntu 22.04. I believe there is something related on Discovering: System.Diagnostics.Process.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Diagnostics.Process.Tests (found 263 of 324 test cases)
Starting: System.Diagnostics.Process.Tests (parallel test collections = on [2 threads], stop on fail = off)
System.Diagnostics.Tests.ProcessThreadTests.TestStartTimeProperty [FAIL]
Assert.Single() Failure: The collection did not contain any matching items
Expected: (predicate expression)
Collection: [System.Diagnostics.ProcessThread, System.Diagnostics.ProcessThread, System.Diagnostics.ProcessThread, System.Diagnostics.ProcessThread, System.Diagnostics.ProcessThread, ···]
Stack Trace:
/_/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs(156,0): at System.Diagnostics.Tests.ProcessThreadTests.<>c__DisplayClass4_0.<TestStartTimeProperty>b__0()
/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs(179,0): at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs(203,0): at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
/_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs(2342,0): at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
/_/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs(149,0): at System.Diagnostics.Tests.ProcessThreadTests.TestStartTimeProperty()
--- End of stack trace from previous location ---
Finished: System.Diagnostics.Process.Tests |
After consultation and collaborative investigation, we've concluded that the failures we're seeing are the same as in the rolling build for the branch. Safe to merge. |
Applied |
Related: