Replace readdir_r call in TimeZoneInfo.Unix #116119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozkee
requested review from
stephentoub,
adamsitnik,
mdh1418,
a team and
Copilot
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the legacy readdir_r code with the newer FileSystemEnumerable API for enumerating time zone files in Unix, while also cleaning up some static field names and unused variables in the test suite.
- Renames a static byte array field in TimeZoneInfoTests.cs to follow static naming conventions.
- Removes an unused local variable in TimeZoneInfoTests.Common.cs.
- Replaces a custom recursive directory enumeration with FileSystemEnumerable in TimeZoneInfo.Unix.NonAndroid.cs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/TimeZoneInfoTests.cs | Renamed static field and updated test usages accordingly. |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/TimeZoneInfoTests.Common.cs | Removed an unused local variable. |
| src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Unix.NonAndroid.cs | Replaced readdir_r-based enumeration with FileSystemEnumerable; review the return logic in FindTimeZoneId. |
src/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Unix.NonAndroid.cs
Show resolved
Hide resolved
jozkee
added
area-System.DateTime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-datetime |
tarekgh
reviewed
May 29, 2025
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/TimeZoneInfoTests.cs
Show resolved
Hide resolved
|
/azp run runtime-androidemulator |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tarekgh
approved these changes
May 29, 2025
jozkee
changed the title
adamsitnik
approved these changes
May 30, 2025
|
/ba-g I have no idea how to proceed with the error on HostActivation.Tests (there's no console log), but its clearly unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while investigating something else. It's possible System.IO was not initially used because the assembly was just folded into System.PrivateCoreLib (#53231) when the change to TimeZoneInfo was made 46d9b31.