Add STJ 8.0.5 #1060
Add STJ 8.0.5 #1060
Conversation
|
|
||
| public sealed partial class JsonCollectionInfoValues<TCollection> | ||
| { | ||
| public JsonTypeInfo ElementInfo { get { throw null; } init { } } |
There was a problem hiding this comment.
The init is incorrectly generated here and should be changed to set. See #861 (comment).
There was a problem hiding this comment.
Is there a plan to update the tooling to handle this? This is already far too much friction for updating a single version number and it's only going to get worse as the push to get these updated asap ramps up.
There was a problem hiding this comment.
Also, the generate command when I ran it generated a bunch of additional files that I had to mentally filter out for other packages (System.Text.Encodings.Web, System.Runtime.InteropServices, and Microsoft.Bcl.asyncingterfaces). It'd be great to clean up the generation tool for that as well because if we're going to enable nuget audit and be updating packages regularly that aren't in source build, we need the process to be as smooth as possible.
There was a problem hiding this comment.
Also, the generate command when I ran it generated a bunch of additional files that I had to mentally filter out for other packages (System.Text.Encodings.Web, System.Runtime.InteropServices, and Microsoft.Bcl.asyncingterfaces). It'd be great to clean up the generation tool for that as well because if we're going to enable nuget audit and be updating packages regularly that aren't in source build, we need the process to be as smooth as possible.
This is called out in https://github.com/dotnet/source-build-reference-packages?tab=readme-ov-file#workflow. It is ok to include those changes.
I ran the generate command, added the STJ items, and updated the build.props. We need it for this and various other PRs into the templating repo which has a hardcoded STJ version as it doesn't get it through codeflow: dotnet/templating#8430
I'm a bit surprised no one else needed a the SBRP update for STJ.