-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support for consumer-aware OffsetFetchRequest and OffsetCommitRequest #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,9 @@ | |
10 : 'MESSAGE_SIZE_TOO_LARGE', | ||
11 : 'STALE_CONTROLLER_EPOCH', | ||
12 : 'OFFSET_METADATA_TOO_LARGE', | ||
14 : 'OFFSETS_LOAD_IN_PROGRESS', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possible typo? Should say 'OFFSET_LOAD_IN_PROGRESS' to be consistent with protocol.py, 452. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This pull request is pretty old, and was made against the dev branch. It might have changed names since then. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, it’s really old and needs to be rebased. I haven’t had a chance to do it yet, however. -Todd From: Mark Roberts <[email protected]mailto:[email protected]> In kafka/common.py:
This pull request is pretty old, and was made against the dev branch. It might have changed names since then. — There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah right. Checked this out hoping to resolve some issues offset commit On Mon Dec 08 2014 at 18:03:47 toddpalino [email protected] wrote:
|
||
15 : 'CONSUMER_COORDINATOR_NOT_AVAILABLE', | ||
16 : 'NOT_COORDINATOR_FOR_CONSUMER', | ||
} | ||
|
||
class ErrorMapping(object): | ||
|
@@ -92,6 +95,18 @@ class LeaderUnavailableError(KafkaError): | |
pass | ||
|
||
|
||
class OffsetLoadInProgressError(KafkaError): | ||
pass | ||
|
||
|
||
class CoordinatorUnavailableError(KafkaError): | ||
pass | ||
|
||
|
||
class ConsumerMetadataNotSupportedError(KafkaError): | ||
pass | ||
|
||
|
||
class PartitionUnavailableError(KafkaError): | ||
pass | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this should be a flag. If it fails once, won't it fail every time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the situation where the client survives a cluster upgrade. It could be considered a corner case, and not worth supporting, however. I'm more concerned about the behavior in _send_broker_aware_request that will cause this request to get sent to every broker even if it's unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it always require two round trips if you aren't using a kafka server that supports this API request (eg, any production kafka cluster outside LinkedIn?)