Sanity test for consumer.topics() and consumer.partitions_for_topic() #1829
Conversation
test/test_consumer_group.py
Outdated
| @pytest.mark.skipif(not version(), reason="No KAFKA_VERSION set") | ||
| def test_consumer_topics(kafka_broker, topic, version): | ||
| consumer = KafkaConsumer(bootstrap_servers=get_connect_str(kafka_broker)) | ||
| consumer.subscribe([topic]) |
There was a problem hiding this comment.
Is subscribe() needed? Couldn't you just call topics() and partitions_for_topic() since they are both blocking for metadata? You may need to poll() at some point (even without an active subscription) in order to drive the I/O.
There was a problem hiding this comment.
Let me try that -- I do think it'd be good to add on other tests eventually that would check subscribe() and other methods
There was a problem hiding this comment.
@jeffwidman I changed the test to just have poll and removed subscribe
There was a problem hiding this comment.
I do think it'd be good to add on other tests eventually that would check subscribe() and other methods
Absolutely agree. Happily welcome a PR. Just rather keep those in a separate test.
Baisang
force-pushed
the
baisang/partitions_for_topic_test
branch
from
1d896ee to
28a886c
Compare
|
Thanks again for this! |
This should hopefully address #1810. A really simple sanity check for the two methods (I guess it's also a sanity check for
subscribe()as well)This change is