Pass through keyword arguments to send_produce_request #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to take a while to get to this one. I opened issue #395 for this issue. I dont want to merge this PR as is because I would prefer not to expose the internal client api kwargs directly to the consumer, and also it makes unit testing a bit more difficult. Instead I put up #396 to support fail_on_error configuration. Because this affects the I intend to merge that and include in the forthcoming 0.9.4 release. If you want/need better callback support (the other internal producer kwarg), I think it is worth opening a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its currently not possible to set the
fail_on_errorkeyword argument inclient.send_produce_requestfrom the Producer.