Skip to content

Async producer retries for failed messages #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 4, 2015
Merged

Async producer retries for failed messages #331

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b82f94f
Retries for async batching
vshlapakov Feb 25, 2015
81d8688
Fixed base producer imports
vshlapakov Feb 25, 2015
4b8288a
Producer _send_upstream fixes, added tests for retries
vshlapakov Feb 26, 2015
a9324f3
Fixed compatible issues with tests
vshlapakov Feb 26, 2015
566e408
Fix: check failed reqs to retry only for positive limit
vshlapakov Feb 26, 2015
b0a0459
Returned default behaviour with no retries
vshlapakov Feb 26, 2015
5e8dc6d
Fixed tests and other issues after rebase
vshlapakov Mar 24, 2015
09c1c8b
Improved retry logic
vshlapakov Apr 21, 2015
0e0f794
Arg fixes for base/keyed producers
vshlapakov Apr 21, 2015
b311145
Clean and simplify retry logic
vshlapakov Apr 21, 2015
c165f17
Disable retry on timeouts by default (old behaviour)
vshlapakov Apr 21, 2015
cf36308
add producer send batch queue overfilled test
Jan 23, 2015
f41e5f3
async queue: refactored code; add one more test
ediskandarov Jan 23, 2015
948e046
Fix small issues with names/tests
vshlapakov Apr 21, 2015
7da48f6
Simplification of retry logic
vshlapakov Apr 22, 2015
5119bb6
Fix names for async retries opts, add timeout for put
vshlapakov Apr 22, 2015
91af27c
Fix async producer queue put arguments
vshlapakov Apr 22, 2015
9eed169
Change backoff message log level
vshlapakov Apr 22, 2015
4c682f3
Increase producer test timeout
vshlapakov Apr 22, 2015
a3fb322
Improve async producer code: logic and style fixes
vshlapakov May 15, 2015
4474a50
Async producer: py2.6 backward compatibility fix
vshlapakov May 15, 2015
7d6f3f5
Check response.error for async producer
vshlapakov Jun 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable retry on timeouts by default (old behaviour)
  • Loading branch information
@vshlapakov
vshlapakov committed Jun 3, 2015
commit c165f17338c0a9260a91b816f73e5ce4ff7ed359
2 changes: 1 addition & 1 deletion kafka/producer/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
BATCH_SEND_DEFAULT_INTERVAL = 20
BATCH_SEND_MSG_COUNT = 20
BATCH_RETRY_OPTIONS = RetryOptions(
limit=0, backoff_ms=300, retry_on_timeouts=True)
limit=0, backoff_ms=300, retry_on_timeouts=False)

STOP_ASYNC_PRODUCER = -1

Expand Down