Skip to content

Migrate to uv #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 11, 2025
Merged

Migrate to uv #2455

merged 9 commits into from
Apr 11, 2025

Conversation

colinjc
Copy link
Contributor

@colinjc colinjc commented Mar 28, 2025

Was curious about the level of effort this would take with Cursor and got bored, so here's a quick and dirty attempt to moving over to uv.

@peterschmidt85 peterschmidt85 requested a review from r4victor March 29, 2025 17:10
@r4victor
Copy link
Collaborator

@colinjc, We do not currently have issues with pip/setuptools so there needs to be a rationale for moving to uv. I may assume it may be beneficial for using in CI if it speeds up installation. Any numbers on that compared to dstack pip installation times?

If you gonna proceed with the PR, CONTRIBITING should be updated to use uv, as well as all GitHub actions.

@r4victor
Copy link
Collaborator

Answering my own question: dstack installation time in CI went from 1m to 5s, which is substantial improvement.

@colinjc
Copy link
Contributor Author

colinjc commented Mar 31, 2025

Answering my own question: dstack installation time in CI went from 1m to 5s, which is substantial improvement.

Also makes checking out the repo for the first time to contribute much faster!

If you gonna proceed with the PR, CONTRIBITING should be updated to use uv, as well as all GitHub actions.

Done

@r4victor
Copy link
Collaborator

r4victor commented Apr 1, 2025

@colinjc, I don't have a time for a thorough review atm, but the PR certainly has some TODOs and is not ready for a merge. I think someone from the core team will be able to move it forward in a few weeks.

@r4victor r4victor self-assigned this Apr 11, 2025
@r4victor r4victor merged commit 676e0a3 into dstackai:master Apr 11, 2025
24 checks passed
@r4victor r4victor mentioned this pull request Apr 11, 2025
@r4victor
Copy link
Collaborator

Made a few changes and fixes and merged. Works great for development and CI. Also tested uv publish on test.pypi.org. We'll see how the release workflow works with the 0.19.4rc1 release.

@colinjc thanks a lot for the initiative!

Bihan pushed a commit to Bihan/dstack that referenced this pull request Apr 12, 2025
* Migrate to pyproject.toml

* Include server extras in backends extras

* Use uv for release workflow

* Mention uv sync --all-extras --active

* Remove --frozen

* Use uv to publish to pypi

* Replace pip with uv in actions

* Require httpbin to be compatible with Werkzeug 3

---------

Co-authored-by: Victor Skvortsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants