[runner] Rework env variables exporting #2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `~/.ssh/environment` (processed by OpenSSH) with a shell script exporting env variables. The shell script is sourced in `/etc/profile`, which is only executed by login shell. Advantages: * multi-line variables support (e.g, `DSTACK_NODES_IPS`) * no hard limit of 1000 variables * shared by all users * vars are not redefined by `pam_env` (`/etc/environment`) * it's unlikely that `/tmp/dstack_profile` and `/etc/profile` are located on a volume, unlike `~/.ssh`; no need for cleanup Tested supported shells: * dash (Debian and derivatives, BusyBox distros, e.g., Alpine) * bash as sh (Fedora and downstream distros) * bash (almost every distro) Not supported shells (do not use `/etc/profile`): * zsh * fish Fixes: #2371
r4victor
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
~/.ssh/environment(processed by OpenSSH) with a shell script exporting env variables. The shell script is sourced in/etc/profile, which is only executed by login shell.Advantages:
DSTACK_NODES_IPS)pam_env(/etc/environment)/tmp/dstack_profileand/etc/profileare located on a volume, unlike~/.ssh; no need for cleanupTested supported shells:
Not supported shells (do not use
/etc/profile):Fixes: #2371