File Descriptor Leak through Import #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'fd' in do_import() was leaked. It caused an issue in a deployment where we were updating the data source every 15 minutes and tried to use the 'import' API to update the data source (without dumping the existing data). The fix is to have a global 'if_fd' in place of the local 'fd' and close it before opening the file again in do_import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'fd' in do_import() was leaked. It caused an issue in a deployment where we were updating the data source every 15 minutes and tried to use the 'import' API to update the data source (without dumping the existing data).
The fix is to have a global 'if_fd' in place of the local 'fd' and close it before opening the file again in do_import.