[csharp] add a callback-based ServiceClient API and a corresponding C# sample #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,8 +24,9 @@ find_package(eCAL REQUIRED) | |||
| macro(ecal_add_csharp_core_sample sample_name) | |||
| ecal_add_sample(${sample_name} ${sample_name}.cs) | |||
| target_link_libraries(${sample_name} PRIVATE Eclipse.eCAL.Core) | |||
| set_property(TARGET ${sample_name} PROPERTY FOLDER samples/csharp/binary/service) | |||
| set_property(TARGET ${sample_name} PROPERTY FOLDER samples/csharp/core/service) | |||
There was a problem hiding this comment.
Suggested change
| set_property(TARGET ${sample_name} PROPERTY FOLDER samples/csharp/core/service) | |
| set_property(TARGET ${sample_name} PROPERTY FOLDER samples/csharp/services/binary) |
at least this is analog to C / C++ (Python is still a bit different).
There was a problem hiding this comment.
Unfortunately it's not that easy to align with the other languages. Currently the C# samples are aligned to the 3 C# modules (core, protobuf, string). So there are C# Core (binary) samples for pubsub and service. For C# Protobuf we have typed pubsub and monitoring. For C# String we have typed pubsub. I would keep it like it is, so the solution structure is reflecting the C# modules structure.
Peguen
added
cherry-pick-to-support/v6.0
Peguen
force-pushed
the
csharp/add-client-callback-variant
branch
from
4022718 to
87984da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new, callback-based variant of the service client call (CallWithCallback) alongside the existing CallWithResponse. It also adds or updates C# sample code to demonstrate the new API.
API Changes
ServiceClient(String^ serviceName)allowing creation of a client without explicitly providing aServiceMethodInformationList^.ServiceClient::CallWithCallback(String^ methodName, array<Byte>^ request, ResponseCallback^ callback, int timeoutMs)to the C# wrapper.Sample Added