Remove hue from ImageColorTransformer#forHSB #2060 #2091
Conversation
The ImageColorTransformer introduced for disabled icon calculation has a default implementation taking hue, saturation, brightness and alpha factors for transformation. The hue factor was by accident limited to 1, even though it is a value between 0 and 360. In addition, a multiplication of a hue value with a factor is not reasonable at all. This change removes the ability to change the hue of a color value, as the existing usage of that method does not change the hue anyway. It renames the method accordingly. Fixes eclipse-platform#2060 Co-authored-by: Manuel Killinger <[email protected]>
|
@killingerm I have created this PR with you as co author as the fix should be in M2 (in case people start using the new disablement algorithm already promoted via the new and noteworty) and today is last chance to do it. I have also adapted you proposal as applying a factor to a hue value does, in my opinion, not make any sense anyway and since that value is not used by the existing consumers, I have now simply removed it. |
@HeikoKlare Thank you for fixing it, my IDE broke after an update and I had to reinstall therefore din't manage it in time. Also just removing it was probably the best option. |
|
No worries, I just urged with this to have a proper version of the disablement algorithm provided with M2, so to not ship a broken one that may give a bad first impression. |
The ImageColorTransformer introduced for disabled icon calculation has a default implementation taking hue, saturation, brightness and alpha factors for transformation. The hue factor was by accident limited to 1, even though it is a value between 0 and 360. In addition, a multiplication of a hue value with a factor is not reasonable at all.
This change removes the ability to change the hue of a color value, as the existing usage of that method does not change the hue anyway. It renames the method accordingly.
Fixes #2060