fix: use node ID instead of running index for menu

[kittaakos]

What it does

This PR switches from a running index (number) menu handler to the menu node's technical ID (string).

How to test

Start the example electron app, and once you see the Sample Menu popping up, click File > New File multiple times. When the app loads, the highest number of Untitled-$NUMBER equals the times you click on the New File menu during the app startup. So if you click the menu thrice, expect to see Untitled-3.

Closes #12493

12493.mp4

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[kittaakos]

Can you please help with this, @tsmaeder? Thank you!

[JonasHelming]

@tsmaeder Ping?

[tsmaeder]

@kittaakos finally had time to come back to this one. The implementation here does not really reflect the discussion in #12493. How shall we proceed?

[kittaakos]

Another bug this PR should cover is the very first non-functional context menu item. Handler IDs start from 0:

theia/packages/core/src/electron-browser/preload.ts

Line 36 in 20e3771

let nextHandlerId = 0;

The internal node ID is incremented here:

theia/packages/core/src/electron-browser/preload.ts

Line 48 in 20e3771

handlerId = nextHandlerId++;

But it won't work here because it will be 0:

theia/packages/core/src/electron-main/electron-api-main.ts

Line 237 in 20e3771

if (dto.handlerId) {

The following DTO does not get a click handler:

{
  "id": "file.newFile",
  "accelerator": "Cmd+Shift+N",
  "label": "New Tab",
  "handlerId": 0,
  "checked": false,
  "enabled": true,
  "type": "normal",
  "visible": true
}

[tsmaeder]

@kittaakos finally had time to come back to this one. The implementation here does not really reflect the discussion in #12493. How shall we proceed?

Ping?

[kittaakos]

Thanks for the ping. I have not had time to return to this PR; it's in draft.

Downstream, we use the proposed fix since 1.37.0.

[kittaakos]

Closing due to lack of interest.