editor: fix 'auto-save' listener #8727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit fixes an issue with the listener to the `editor.autoSave` preference update which would call `saveAll` prematurely when the application is loaded. The logic has been updated in order to only call `saveAll` when it is appropriate (a true update to the preference value). Signed-off-by: vince-fugnitto <[email protected]> Co-authored-by: Akos Kitta <[email protected]>
vince-fugnitto
added
bug
|
Much appreciated that you've put together a PR with the fix, @vince-fugnitto. I think the root cause is that the default preference is I wouldn't rush with the merge; there is a workaround. |
Closing for the moment 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8722
The following pull-request addresses an issue with the preference change event for
editor.autoSavewhich would incorrectly process the event on app startup leading to an incorrectshell.saveAll()call. The logic for handling the event has been updated to only execute the handler when theautoSavepreference is actually updated.Thanks to @kittaakos for finding the bug and providing a quick fix.
How to test
autoSaveoff - the listener should not callshell.autoSaveon startupautoSaveon - the listener should not callshell.autoSaveon startupautoSaveoffautoSaveto onReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]
Co-authored-by: Akos Kitta [email protected]