Skip to content

[CI] Allow to run each cloud cleanup step independently in DRY_RUN false mode #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented May 7, 2025

Use different DRY_RUN environment variable names for each step to be able to choose which one to enable.

@mrodm mrodm changed the title Set the expected COMMAND when DRY_RUN is false [CI] Set the expected COMMAND when DRY_RUN is false in cleanup job May 7, 2025
Use different DRY_RUN env. vars for each step.
@mrodm mrodm force-pushed the cleanup-resource-no-dryrun-command branch from 9c15c2b to 7054f85 Compare May 7, 2025 10:23
@mrodm mrodm self-assigned this May 7, 2025
@mrodm mrodm changed the title [CI] Set the expected COMMAND when DRY_RUN is false in cleanup job [CI] Allow to run each cloud cleanup step independently in DRY_RUN false mode May 7, 2025
@mrodm mrodm marked this pull request as ready for review May 7, 2025 11:46
@mrodm mrodm requested a review from a team as a code owner May 7, 2025 11:46
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand this PR 🤔 How would we run each step independently with DRY_RUN false?

@mrodm
Copy link
Contributor Author

mrodm commented May 7, 2025

I don't fully understand this PR 🤔 How would we run each step independently with DRY_RUN false?

Sorry, I did not add that explanation. These changes introduce a new selector in the Buildkite UI, so the user can select which step is going to be run in DRY_RUN mode.

  • DRY_RUN would just be honored by the new step (OIDC)
  • DRY_RUN_DEPRECATED would just be honored by the previous step.

Input variables selector

@jsoriano
Copy link
Member

jsoriano commented May 7, 2025

Oh ok, I misunderstood, I thought that we were fully deprecating the current variable, but I was missing what was replacing it. Thanks.

@mrodm mrodm merged commit 356745d into elastic:main May 8, 2025
3 checks passed
@mrodm mrodm deleted the cleanup-resource-no-dryrun-command branch May 8, 2025 08:15
v1v added a commit to v1v/elastic-package that referenced this pull request May 8, 2025
* main:
  chore: [updatecli] Update latest snapshot to 9.1.0-4348ed5d (elastic#2582)
  [CI] Allow to run each cloud cleanup step independently in DRY_RUN false mode (elastic#2581)
  buildkite: use GCP OIDC (elastic#2569)
  Replace archiver dependency (elastic#2564)
  github-action: add catalog-validate for GitHub actions (elastic#2576)
  chore: [updatecli] Update latest snapshot to 9.1.0-62329fee (elastic#2580)
  Chore(deps): bump golang.org/x/tools from 0.32.0 to 0.33.0 (elastic#2577)
  Chore(deps): bump gotest.tools/gotestsum from 1.12.1 to 1.12.2 (elastic#2578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants