Skip to content

Update healthcheck settings for fleet-server #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 9, 2025

Relates elastic/integrations#14022

Update health-check settings for Fleet-Service container (docker-compose) to be similar to the ones configured for the elastic-agent container.

Current settings for elastic-agent container:

    healthcheck:
      test: "elastic-agent status"
      timeout: 2s
      start_period: 360s
      retries: 180
      interval: 5s

Docs Reference: https://docs.docker.com/reference/dockerfile/#healthcheck

 ✔ Container elastic-package-stack-package-registry-1           Healthy                6.5s 
 ✔ Container elastic-package-stack-elasticsearch-1              Healthy               37.0s
 ✔ Container elastic-package-stack-elasticsearch_is_ready-1     Started               37.1s
 ✔ Container elastic-package-stack-package-registry_is_ready-1  Started                6.6s 
 ✔ Container elastic-package-stack-kibana-1                     Healthy               47.7s
 ✔ Container elastic-package-stack-kibana_is_ready-1            Started               47.8s
 ✔ Container elastic-package-stack-fleet-server-1               Healthy              132.3s
 ✔ Container elastic-package-stack-elastic-agent-1              Healthy              234.5s
 ✔ Container elastic-package-stack-fleet-server_is_ready-1      Started              132.4s
 ✔ Container elastic-package-stack-elastic-agent_is_ready-1     Started              234.5s

How to test this PR locally

Tested locally with 9.1.0-SNAPSHOT

#!/bin/bash

set -euo pipefail

VERSION="9.1.0-SNAPSHOT"
ITER_MAX=10
for i in `seq 1 ${ITER_MAX}`; do
    elastic-package stack down -v
    elastic-package stack up -v -d --version "${VERSION}"
    if [[ "$?" != 0 ]]; then
        echo "ERROR: stack up failed"
        exit 1
    fi
done

Author's Checklist

  • Test packages in integrations repository including this elastic-package PR change.
  • Test locally to run elastic-package stack up (up to 50 iterations using the script shown above).

@mrodm mrodm self-assigned this Jun 9, 2025
@@ -103,8 +103,9 @@ services:
condition: service_healthy
healthcheck:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the timeout with the default value (30 secs)
https://docs.docker.com/reference/dockerfile/#healthcheck

@mrodm
Copy link
Contributor Author

mrodm commented Jun 9, 2025

test integrations

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#14185

@mrodm mrodm marked this pull request as ready for review June 9, 2025 15:50
@mrodm mrodm requested a review from a team June 9, 2025 15:50
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍

@mrodm mrodm merged commit bfebbd1 into elastic:main Jun 10, 2025
3 checks passed
@mrodm mrodm deleted the update-healthcheck-fleetserver branch June 10, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants