Skip to content

[8.14] Validate stats formatting in standard InternalStats constructor (#107678) #107851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Apr 24, 2024

Backports the following commits to 8.14:

…tic#107678)

We want to validate stats formatting before we serialize to XContent, as chunked x-content serialization
 assumes that we don't throw exceptions at that point. It is not necessary to do it in the StreamInput constructor 
as this one has been serialise from an already checked object.

This commit adds starts formatting validation to the standard InternalStats constructor.
@iverase iverase added :Analytics/Aggregations Aggregations >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 24, 2024
@elasticsearchmachine elasticsearchmachine merged commit 5d0e72a into elastic:8.14 Apr 24, 2024
@iverase iverase deleted the backport/8.14/pr-107678 branch April 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.14.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants