ESQL: Fix conversion of a Lucene wildcard pattern to a regexp #128750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the reserved optional characters to the list that is escaped during conversion. These characters are all enabled by the RegExp.ALL flag in our use.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @bpintea, I've created a changelog YAML for you. |
astefan
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
While testing this I find it difficult to come up with a test that proves this functionality. Would you mind adding a single IT test for this, please?
nik9000
approved these changes
Jun 3, 2025
Needed to trigger filter pushdown.
|
Thanks Andrei and Nik! |
bpintea
added
the
auto-merge-without-approval
luigidellaquila
approved these changes
Jun 3, 2025
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Jun 4, 2025
…c#128750) This adds the reserved optional characters to the list that is escaped during conversion. These characters are all enabled by the `RegExp.ALL` flag in our use. Closes elastic#128676, closes elastic#128677. (cherry picked from commit 5eb54bf)
elasticsearchmachine
added a commit
that referenced
this pull request
Jun 5, 2025
) (#128750) (#128753) (#128919) * ESQL: Pushdown constructs doing case-insensitive regexes (#128393) This introduces an optimization to pushdown to Lucense those language constructs that aim at case-insensitive regular expression matching, used with `LIKE` and `RLIKE` operators, such as: * `| WHERE TO_LOWER(field) LIKE "abc*"` * `| WHERE TO_UPPER(field) RLIKE "ABC.*"` These are now pushed as case-insensitive `wildcard` and `regexp` respectively queries down to Lucene. Closes #127479 (cherry picked from commit 0a80916) * ESQL: Fix conversion of a Lucene wildcard pattern to a regexp (#128750) This adds the reserved optional characters to the list that is escaped during conversion. These characters are all enabled by the `RegExp.ALL` flag in our use. Closes #128676, closes #128677. (cherry picked from commit 5eb54bf) * ESQL: Fix case-insensitive test generation with Unicodes (#128753) This excludes from testing the strings containing Unicode chars that change length when changing case. Closes #128705 Closes #128706 Closes #128710 Closes #128711 Closes Closes #128717 Closes #128789 Closes #128790 Closes #128791 Closes (cherry picked from commit 092d4ba) * [CI] Auto commit changes from spotless * Java21 adaptations and automerge fixes * [CI] Auto commit changes from spotless * 8.x's Lucene/RegExp doesn't support case-insensitive matching * [CI] Auto commit changes from spotless * One more Lucene 9 fix --------- Co-authored-by: elasticsearchmachine <[email protected]>
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 5, 2025
…es (elastic#128393) (elastic#128750) (elastic#128753) (elastic#128919)" This reverts commit 34e08fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the reserved optional characters to the list that is escaped
during conversion. These characters are all enabled by the
RegExp.ALLflag in our use.
Closes #128676, closes #128677.