Skip to content

Add the fact that you'll need to find te snapshot before trying to re… #92941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.1
Choose a base branch
from

Conversation

lhirlimann
Copy link
Member

…store ir

And it's document above.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jan 16, 2023
@elasticsearchmachine
Copy link
Collaborator

@lhirlimann please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.1.4 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 16, 2023
@lhirlimann lhirlimann added the Team:Docs Meta label for docs team label Jan 17, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Docs Meta label for docs team label Jan 17, 2023
@lhirlimann
Copy link
Member Author

@lhirlimann please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

I'm failing to follow the doc :(

@DaveCTurner DaveCTurner added the :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Jan 17, 2023
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. and removed needs:triage Requires assignment of a team area label labels Jan 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor

Thanks for the suggestion @lhirlimann! However, I don't think we should make this change. I would have expected that it is already clear enough that you do indeed need to choose a snapshot to restore as part of this process. Your PR suggests that this wasn't the case for you, in which case I think this needs to be called out much earlier on this page. The section about listing the available snapshots looks like a much better location for this info.

@DaveCTurner
Copy link
Contributor

I'm failing to follow the doc :(

Don't worry about it, it's not a big deal 🙂

@lhirlimann
Copy link
Member Author

Thanks for the suggestion @lhirlimann! However, I don't think we should make this change. I would have expected that it is already clear enough that you do indeed need to choose a snapshot to restore as part of this process. Your PR suggests that this wasn't the case for you, in which case I think this needs to be called out much earlier on this page. The section about listing the available snapshots looks like a much better location for this info.

I was following the numbers to restore a cluster - in I'm in a hurry mode , cluster is down, and I felt It would be nice to also state that there's a step to look for the proper snapshot to be searched and found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs external-contributor Pull request authored by a developer outside the Elasticsearch team feedback_needed Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants