-
Notifications
You must be signed in to change notification settings - Fork 462
[sentinel_one_cloud_funnel] Add Support for Azure Blob Storage Input #14124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sentinel_one_cloud_funnel] Add Support for Azure Blob Storage Input #14124
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What testing has been done for this change?
@efd6 This has also been included in the commit message. |
@mohitjha-elastic, let's attach a screen recording of the live testing with an actual blob storage for future context. |
@ShourieG Please find the attached recording here: s1-event-recording.mp4 |
@mohitjha-elastic Yes, I understand that testing can't be included in the package, but I'd like to know whether this was tested against a real endpoint. I think this is answered by:
Am I interpreting that correctly? The video above suggests that I am. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like a second from @ShourieG.
Hi @mohitjha-elastic, since we are adding fresh support for azure blob storage, lets also add the RBAC oauth2 config options introduced in this PR as an optional auth config. We need to keep min stack version of 8.16 for this. |
Add options to fetch data using azure RBAC OAuth2 authentication.
@ShourieG Recording: Screenshot: |
Add role description in readme
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
packages/sentinel_one_cloud_funnel/data_stream/event/manifest.yml
Outdated
Show resolved
Hide resolved
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package sentinel_one_cloud_funnel - 1.13.0 containing this change is available at https://epr.elastic.co/package/sentinel_one_cloud_funnel/1.13.0/ |
Proposed Commit Message
Checklist
changelog.yml
file.How to test this PR locally
To test sentinel_one_cloud_funnel integration
Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/sentinel_one_cloud_funnel directory.
Run the following command to run tests.
elastic-package test -v
Related issues