Skip to content

add github/user-type action #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 9, 2025
Merged

add github/user-type action #294

merged 8 commits into from
Jun 9, 2025

Conversation

SylvainJuge
Copy link
Member

Turns out that filtering of bots is actually required to simplify the "triage" workflows in elastic/elastic-otel-java#679.

So I have created this simple github/is-bot action to wrap the API call and hopefully make it easier to maintain and use.

@SylvainJuge SylvainJuge changed the title add github/is-bot action add github/user-type action Jun 9, 2025
@SylvainJuge SylvainJuge added the changelog:feature When you add a new feature label Jun 9, 2025
@SylvainJuge SylvainJuge self-assigned this Jun 9, 2025
@SylvainJuge SylvainJuge marked this pull request as ready for review June 9, 2025 13:08
@SylvainJuge SylvainJuge requested a review from a team June 9, 2025 13:09
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few comments:

  • use lowercase for the user-type output, maybe?
  • configure the tests with less permissions access

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor cosmetic change in the docs

@SylvainJuge
Copy link
Member Author

I've changed to using a lowercase result as it's simpler to consume (and hides a bit the GH implementation details).

For the permissions, I thought that we had to explicitly use it for extra permissions that were required, and there getting details on an user does not require any special privileges. As it turns out it's a way to limit the token permissions I agree it's better to limit the least privilege.

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again Sylvain! 🙇

@SylvainJuge SylvainJuge added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 05ae3fb Jun 9, 2025
7 checks passed
@SylvainJuge SylvainJuge deleted the github-is-bot branch June 9, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:feature When you add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants