-
Notifications
You must be signed in to change notification settings - Fork 7
add github/user-type action #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few comments:
- use lowercase for the user-type output, maybe?
- configure the tests with less permissions access
Co-authored-by: Victor Martinez <[email protected]>
Co-authored-by: Victor Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor cosmetic change in the docs
I've changed to using a lowercase result as it's simpler to consume (and hides a bit the GH implementation details). For the permissions, I thought that we had to explicitly use it for extra permissions that were required, and there getting details on an user does not require any special privileges. As it turns out it's a way to limit the token permissions I agree it's better to limit the least privilege. |
Co-authored-by: Victor Martinez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again Sylvain! 🙇
Turns out that filtering of bots is actually required to simplify the "triage" workflows in elastic/elastic-otel-java#679.
So I have created this simple
github/is-bot
action to wrap the API call and hopefully make it easier to maintain and use.