Added telemetry for Kibana #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
approved these changes
May 8, 2025
start-local.sh
Outdated
| @@ -630,7 +631,7 @@ EOM | |||
| cat >> uninstall.sh <<- EOM | |||
| $docker_clean | |||
| $docker_remove_volumes | |||
| rm docker-compose.yml .env uninstall.sh start.sh stop.sh | |||
| rm -rf docker-compose.yml .env uninstall.sh start.sh stop.sh config/ | |||
There was a problem hiding this comment.
This is a bit risky if, in the future, we allow customers to mount their own config/kibana.yml.
But that doesn't seem to be the case today.
So not a blocker.
There was a problem hiding this comment.
Good point, maybe it's safet to just remove the config/telemetry.yml file created by start-local.
ezimuel
added a commit
to elastic/kibana
that referenced
this pull request
May 9, 2025
This PR adds the [start-local](https://github.com/elastic/start-local) telemetry keyword. This keyword has [already been merged in start-local](elastic/start-local#52) to inform Kibana that the telemetry are coming from a start-local installation. When this will be merged I can than release a new version of start-local (i.e. 0.9.0). --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 9, 2025
This PR adds the [start-local](https://github.com/elastic/start-local) telemetry keyword. This keyword has [already been merged in start-local](elastic/start-local#52) to inform Kibana that the telemetry are coming from a start-local installation. When this will be merged I can than release a new version of start-local (i.e. 0.9.0). --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]> (cherry picked from commit 55a2c98)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
May 9, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Added the static telemetry for start-local (#220519)](#220519) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Enrico Zimuel","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-09T18:10:50Z","message":"Added the static telemetry for start-local (#220519)\n\nThis PR adds the [start-local](https://github.com/elastic/start-local)\ntelemetry keyword. This keyword has [already been merged in\nstart-local](elastic/start-local#52) to inform\nKibana that the telemetry are coming from a start-local installation.\n\nWhen this will be merged I can than release a new version of start-local\n(i.e. 0.9.0).\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Alejandro Fernández Haro <[email protected]>","sha":"55a2c98e042856e89d029de92f2ed86256938a0e","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"Added the static telemetry for start-local","number":220519,"url":"https://github.com/elastic/kibana/pull/220519","mergeCommit":{"message":"Added the static telemetry for start-local (#220519)\n\nThis PR adds the [start-local](https://github.com/elastic/start-local)\ntelemetry keyword. This keyword has [already been merged in\nstart-local](elastic/start-local#52) to inform\nKibana that the telemetry are coming from a start-local installation.\n\nWhen this will be merged I can than release a new version of start-local\n(i.e. 0.9.0).\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Alejandro Fernández Haro <[email protected]>","sha":"55a2c98e042856e89d029de92f2ed86256938a0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220519","number":220519,"mergeCommit":{"message":"Added the static telemetry for start-local (#220519)\n\nThis PR adds the [start-local](https://github.com/elastic/start-local)\ntelemetry keyword. This keyword has [already been merged in\nstart-local](elastic/start-local#52) to inform\nKibana that the telemetry are coming from a start-local installation.\n\nWhen this will be merged I can than release a new version of start-local\n(i.e. 0.9.0).\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>\nCo-authored-by: Alejandro Fernández Haro <[email protected]>","sha":"55a2c98e042856e89d029de92f2ed86256938a0e"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Enrico Zimuel <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
This PR adds the [start-local](https://github.com/elastic/start-local) telemetry keyword. This keyword has [already been merged in start-local](elastic/start-local#52) to inform Kibana that the telemetry are coming from a start-local installation. When this will be merged I can than release a new version of start-local (i.e. 0.9.0). --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following telemetry for Kibana, generating the
config/telemetry.ymlfile.where
${version}is theSTART_LOCAL_VERSIONenv value, stored in.envfile.