Skip to content

Mark elasticstack_kibana_action_connector.secrets as sensitive #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

henrikno
Copy link
Contributor

@henrikno henrikno commented Mar 8, 2025

Mark secrets in elasticstack_kibana_action_connector as sensitive.

wandergeek
wandergeek previously approved these changes Mar 10, 2025
@wandergeek
Copy link
Contributor

Thanks for your contribution!
LGTM if you can get those tests passing. 👌

@henrikno
Copy link
Contributor Author

        Error: Unexpected status code from server: got HTTP 404
        
          with elasticstack_fleet_integration.test_integration,
          on terraform_plugin_test.tf line 7, in resource "elasticstack_fleet_integration" "test_integration":
           7: resource "elasticstack_fleet_integration" "test_integration" {
        
        {"statusCode":404,"error":"Not Found","message":"[sysmon_linux] package not
        found in registry"}

Seems unrelated to this, and all other PRs are failing with the same issue.

tobio
tobio previously approved these changes Mar 11, 2025
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henrikno, are you able to add an entry to CHANGELOG.md for this one.

@tobio
Copy link
Member

tobio commented Mar 11, 2025

Seems unrelated to this, and all other PRs are failing with the same issue.

Yep, this looks like either a breaking change in 9.0, or an issue with the release. I'll open an issue for it, we shouldn't block this PR on those tests.

@henrikno henrikno dismissed stale reviews from tobio and wandergeek via c9fb2fc March 12, 2025 16:50
@tobio tobio merged commit 08a3a2a into elastic:main Mar 12, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants