Skip to content

Fix schema validation for kibana and fleet configuration #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix schema validation for kibana and fleet configuration #449

merged 3 commits into from
Oct 16, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Oct 16, 2023 •
edited
Loading

Related to #447 (comment)

The path references for username/password were wrong for both these provider config schemas.

@tobio tobio requested a review from wandergeek October 16, 2023 00:24
@tobio tobio self-assigned this Oct 16, 2023
dimuon
dimuon approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit 1107e32 into main Oct 16, 2023
@tobio tobio deleted the fix-fleet-kibana-schema-validation branch October 16, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

@wandergeek wandergeek Awaiting requested review from wandergeek

@taylor-swanson taylor-swanson Awaiting requested review from taylor-swanson

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobio @dimuon