Add Fleet package policies and epm support #454

taylor-swanson · 2023-10-25T21:22:24Z

Add Fleet EPM (Elastic Package Manager) support, currently only provides for installing and uninstalling packages.
Add Fleet Package Policy support.
Add acceptance tests
Add documentation

- Add Fleet EPM (Elastic Package Manager) support, currently only provides for installing and uninstalling packages. - Add Fleet Package Policy support. - Add acceptance tests - Add documentation

internal/clients/config/elasticsearch.go

tobio

Couple of usability questions on the package resource.

internal/fleet/package_resource.go

templates/resources/fleet_package.md.tmpl

internal/fleet/package_resource.go

tobio · 2023-10-30T23:27:56Z

internal/fleet/package_resource.go

+	return *hash
+}
+
+func ResourcePackage() *schema.Resource {


It feels like this resource may be difficult to use without a data source to list the available packages. I'm thinking about how I'd use this right now, where I'd be flicking between the Kibana UI and TF code, but what happens when the package in the repo is upgraded to a new version?

Do you have plans to add that data source in a follow up? If not could we?

These are great points. I've been trying to think of usability concerns (and there are a few when dealing with packages and package policies).

We didn't have explicit plans for a package data source, but we can definitely look into doing that. At a quick glance, the "list packages" endpoint for EPM seems to list the latest package versions only (it doesn't give you a full manifest of what's available in the package registry), as far as I can tell. This should be fine, though, since we really only care about the latest package version.

Wdyt about timing here? I'm inclined to merge this and have the data sources in a follow up?

I would agree as well. I can write a follow up issue for the package data source. (issue here: #468)

internal/fleet/package_resource.go

templates/resources/fleet_package_policy.md.tmpl

tobio

LGTM 🚀

Kushmaro · 2023-11-03T10:05:28Z

@taylor-swanson @tobio , we should definitely have a package data resource as well

taylor-swanson · 2023-11-03T13:17:08Z

@tobio @Kushmaro, see #469 for the package data source PR.

Kushmaro · 2023-11-08T12:30:50Z

hey @taylor-swanson , i'm looking into the UX of the new resources, I might want us to change their name / terminology a bit.
the Fleet UI doesn't mention or discusses at all "Package policies" rather, "integrations". That is what our users know... our UX / wording should be consistent where we can have them so

taylor-swanson · 2023-11-09T14:06:26Z

@Kushmaro, I chose the name based on the terminology used in the API (which refers to integration policies as package policies). We can certainly update documentation to mention/use the term integrations policies instead.

Do you think we should rename the resource as well? If we want to do that, now would be the time. The longer we wait, the more users this would impact, since it would be a breaking change.

elasticstack_fleet_package_policy -> elasticstack_fleet_integration_policy

Kushmaro · 2023-11-09T14:12:41Z

I agree @taylor-swanson that it's not best to wait here.
I know the API refers to package policies, but that kind of excludes the actual user experience. when users go to the fleet management UI , they have no concept of "package policies"

the fact that the UI & API use different terminologies is a separate issue (mainly for the fleet team)
but i'd want us to align the Terraform client experience towards what the user will natively understand from the UI / Product.

taylor-swanson · 2023-11-09T14:17:08Z

@Kushmaro, that makes sense. I'll write up an issue to rename the package policy resource and update documentation. Do you have any thoughts about the package resource and data source (elasticstack_fleet_package)? There are a few things that identify them as "packages" (Elastic Package Registry, Elastic Package Manager, etc), but the Kibana UI and the main docs site seems to refer to them as "integrations" at this point. Although, I thought I've heard that not every package is an integration? (I could be wrong about that, though).

Kushmaro · 2023-11-09T14:50:24Z

i'm no fleet PM , so I don't have full context over these unfortunately. Maybe @nimarezainia can comment.
I do think that for the data resource, we should refer as "fleet_integration"

our UI is really big on using the term "integration" in that space.

taylor-swanson · 2023-11-10T14:43:54Z

Link to refactoring issue: #475

nimarezainia · 2023-11-13T03:35:05Z

agree with both @taylor-swanson and @Kushmaro - average user of the platform would be more familiar with the concept of an "integration" rather than packages which are perhaps more developer focuses. Thanks for making all these changes.

taylor-swanson self-assigned this Oct 25, 2023

Add Fleet package policies and epm support

df2cf33

- Add Fleet EPM (Elastic Package Manager) support, currently only provides for installing and uninstalling packages. - Add Fleet Package Policy support. - Add acceptance tests - Add documentation

taylor-swanson force-pushed the feature/fleet-package-policy branch from 1309198 to df2cf33 Compare October 26, 2023 20:58

taylor-swanson commented Oct 26, 2023

View reviewed changes

internal/clients/config/elasticsearch.go Outdated Show resolved Hide resolved

taylor-swanson added 4 commits October 27, 2023 08:17

Merge branch 'main' into feature/fleet-package-policy

80b10eb

Remove unused config_json and processors_json from read

7dd90d4

Fix docs, cleanup

6a4ba09

Remove unneeded code

03e91a0

taylor-swanson marked this pull request as ready for review October 30, 2023 13:14

tobio reviewed Oct 30, 2023

View reviewed changes

tobio mentioned this pull request Oct 30, 2023

Fix fleet resources not having ID set on import #447

Merged

review comments

b634e98

taylor-swanson mentioned this pull request Nov 1, 2023

Create data source for Fleet integration packages #468

Closed

tobio approved these changes Nov 2, 2023

View reviewed changes

tobio merged commit 0240e14 into elastic:main Nov 2, 2023

BenB196 mentioned this pull request Nov 2, 2023

[Feature] terraform Provider Support for Fleet Integration policies #89

Closed

taylor-swanson deleted the feature/fleet-package-policy branch November 3, 2023 13:17

Add Fleet package policies and epm support #454

Add Fleet package policies and epm support #454

Uh oh!

Conversation

taylor-swanson commented Oct 25, 2023

Uh oh!

Uh oh!

tobio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tobio Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

taylor-swanson Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

tobio Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

taylor-swanson Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tobio left a comment

Choose a reason for hiding this comment

Uh oh!

Kushmaro commented Nov 3, 2023

Uh oh!

taylor-swanson commented Nov 3, 2023

Uh oh!

Kushmaro commented Nov 8, 2023

Uh oh!

taylor-swanson commented Nov 9, 2023

Uh oh!

Kushmaro commented Nov 9, 2023

Uh oh!

taylor-swanson commented Nov 9, 2023

Uh oh!

Kushmaro commented Nov 9, 2023

Uh oh!

taylor-swanson commented Nov 10, 2023

Uh oh!

nimarezainia commented Nov 13, 2023

Uh oh!

Uh oh!

taylor-swanson Nov 1, 2023 •

edited

Loading