Add alerting connector data source #607
Conversation
Co-authored-by: Toby Brain <[email protected]>
wandergeek
force-pushed
the
connector-data-source
branch
from
b6f4fe9 to
7c63a69
Compare
| diag.Errorf("error while creating elasticstack_kibana_action_connector datasource: connector with name [%s/%s] and type [%s] not found", spaceId, connectorName, connectorType) | ||
| } | ||
|
|
||
| if len(foundConnectors) > 1 { |
There was a problem hiding this comment.
I do wonder if it would have been better for this DS to output a list of matching connectors TBH.
There was a problem hiding this comment.
For the use case that I want to use this with, I think this would cause confusion. What I'm trying to facilitate here is the ability to grab a connector by name (eg o11y-alertbot) and use it in an alert without having to create a new connector in the module. If the DS returns >1 connector then its ambiguous what connector is actually being used, particularly if it has been created erroneously.
There was a problem hiding this comment.
Yea, I understand. You could still achieve that by having a check block do the assertion on a single result, whilst the DS would be more flexible for other consumers.
This PR adds a datasource that allows users to retrieve alerting connectors.