Fix: rule_id attribute ignored for elasticstack_kibana_alerting_rule resource

[b-deam]

Similar to #622, currently the rule_id attribute of a elasticstack_kibana_alerting_rule is ignored; we just pass in an empty string:

terraform-provider-elasticstack/internal/clients/kibana/alerting.go

Line 87 in 85accb6

req := client.CreateRule(ctxWithAuth, rule.SpaceID, "").KbnXsrf("true").CreateRuleRequest(reqModel)

This commit fixes this by passing the rule_id attribute's value to the client's API call, if unset, we pass an empty string - the same as existing behaviour.

Note that there's a bug in the Alerting OpenAPI spec that means it's missing the 409 response, so I had to add a manual conflict check upon creation.

We can remove this check when elastic/kibana#183223 is closed, and the swagger version is bumped:

terraform-provider-elasticstack/Makefile

Line 14 in 85accb6

SWAGGER_VERSION ?= 8.7

Tested manually with this TF file:

terraform {
  required_providers {
    elasticstack = {
      source = "elastic/elasticstack"
    }
  }
}

provider "elasticstack" {
  elasticsearch {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:9200"]
    insecure  = true
  }
  kibana {
    username  = "elastic"
    password  = "password"
    endpoints = ["http://localhost:5601"]
    insecure  = true
  }
}

resource "elasticstack_kibana_alerting_rule" "example_no_id" {
  name        = "my-alert-no-id"
  consumer    = "alerts"
  notify_when = "onActiveAlert"
  params = jsonencode({
    aggType             = "avg"
    groupBy             = "top"
    termSize            = 10
    timeWindowSize      = 10
    timeWindowUnit      = "s"
    threshold           = [10]
    thresholdComparator = ">"
    index               = ["kibana_sample_data_logs"]
    timeField           = "@timestamp"
    aggField            = "hour_of_day"
    termField           = "hour_of_day"
  })
  rule_type_id = ".index-threshold"
  interval     = "1m"
  enabled      = true
}


resource "elasticstack_kibana_alerting_rule" "example_id" {
  name        = "my-alert-with-id"
  rule_id = "af22bd1c-8fb3-4020-9249-a4ac5471624c"
  consumer    = "alerts"
  notify_when = "onActiveAlert"
  params = jsonencode({
    aggType             = "avg"
    groupBy             = "top"
    termSize            = 10
    timeWindowSize      = 10
    timeWindowUnit      = "s"
    threshold           = [10]
    thresholdComparator = ">"
    index               = ["kibana_sample_data_logs"]
    timeField           = "@timestamp"
    aggField            = "hour_of_day"
    termField           = "hour_of_day"
  })
  rule_type_id = ".index-threshold"
  interval     = "1m"
  enabled      = true
}

resource "elasticstack_kibana_alerting_rule" "example_conflicting_id" {
  name        = "my-alert-no-id"
  consumer    = "alerts"
  // Conflicts with example_id, should safely catch 409
  rule_id = "af22bd1c-8fb3-4020-9249-a4ac5471624c"
  notify_when = "onActiveAlert"
  params = jsonencode({
    aggType             = "avg"
    groupBy             = "top"
    termSize            = 10
    timeWindowSize      = 10
    timeWindowUnit      = "s"
    threshold           = [10]
    thresholdComparator = ">"
    index               = ["kibana_sample_data_logs"]
    timeField           = "@timestamp"
    aggField            = "hour_of_day"
    termField           = "hour_of_day"
  })
  rule_type_id = ".index-threshold"
  interval     = "1m"
  enabled      = true
}

[dimuon]

LGTM 👍