Skip to content

Kibana spaces data source #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 19, 2024
Merged

Kibana spaces data source #682

merged 12 commits into from
Aug 19, 2024

Conversation

jdesnoes
Copy link
Contributor

Adding a data source to search Kibana spaces by their name.

Copy link

cla-checker-service bot commented Jul 15, 2024

💚 CLA has been signed

@tobio
Copy link
Member

tobio commented Jul 16, 2024

@jdesnoes there's a strong preference for all new resources/data sources to be written with the Terraform plugin framework. This would be the first data source, but the data view resource might be a good example to work from.

@tobio
Copy link
Member

tobio commented Jul 16, 2024

The lint failure is due to automatic docs generation. Are you able to add a template for this data source, along with an example and then run make docs-generate and commit everything.

@tobio
Copy link
Member

tobio commented Jul 16, 2024

FYI you can run the acceptance tests locally against a docker environment with make docker-testacc, or your test specifically with make docker-testacc TESTARGS='-run ^TestAccDataSourceKibanaSpaces$$'

@jdesnoes jdesnoes marked this pull request as ready for review July 18, 2024 08:47
@jdesnoes
Copy link
Contributor Author

Thanks for all your advices @tobio, I just committed a new version of the Kibana spaces data source based on the Terraform plugin framework, with acceptances tests working and documentation generated.

jdesnoes and others added 10 commits August 16, 2024 18:03
Bumps [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases)
- [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-plugin-framework@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/terraform-plugin-framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jdesnoes jdesnoes force-pushed the spaces_data_source branch from 37036cc to 1636949 Compare August 16, 2024 16:03
tobio
tobio previously approved these changes Aug 18, 2024
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's a couple of minor changes, are you able to add an entry to the CHANGELOG for this PR as well?

@jdesnoes
Copy link
Contributor Author

LGTM. There's a couple of minor changes, are you able to add an entry to the CHANGELOG for this PR as well?

Thanks, it's done.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this one!

@tobio tobio merged commit 7773917 into elastic:main Aug 19, 2024
20 checks passed
@jdesnoes jdesnoes deleted the spaces_data_source branch August 23, 2024 07:40
tobio added a commit that referenced this pull request Aug 26, 2024
* origin/main:
  Add support for the `alert_delay` param in the Create Rule API (#715)
  chore: prepare release v0.11.6 (#716)
  Validate that mappings are a JSON object, not just valid json (#719)
  fix: move all resources in one namespace for tcp monitor acc tests (#717)
  Bump github.com/golangci/golangci-lint from 1.59.1 to 1.60.1 in /tools (#714)
  Bump github.com/docker/docker in /tools (#718)
  Bump github.com/goreleaser/goreleaser from 1.26.1 to 1.26.2 in /tools (#642)
  Bump github.com/hashicorp/terraform-plugin-framework (#705)
  Add kibana synthetics http and tcp monitor resources (#699)
  Kibana spaces data source (#682)
  Use ephemeral github token for build. (#712)
  chore: 8.15.0 is here - lets try it out (#708)
  Update changelog for 0.11.5
  Bump version for 0.11.5 (#706)
  Bugfix SLO API: Update type for `group_by` to accept either string or array-of-strings (#701)
  Support `restriction` in `elasticstack_elasticsearch_security_api_key` (#577)
  chore: follow-up CR changes for synthetics private location resource (#697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants