Support alerting rules with only one of kql or timeframe fields #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
kibana-alerting-optional-kql-timeframe
branch
from
0dde820 to
b1334f7
Compare
adcoelho
reviewed
Oct 30, 2024
| resource.TestCheckResourceAttr("elasticstack_kibana_alerting_rule.test_rule", "actions.0.alerts_filter.0.timeframe.0.timezone", "Pacific/Honolulu"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_alerting_rule.test_rule", "actions.0.alerts_filter.0.timeframe.0.hours_start", "02:00"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_alerting_rule.test_rule", "actions.0.alerts_filter.0.timeframe.0.hours_end", "03:00"), | ||
| resource.TestCheckResourceAttr("elasticstack_kibana_alerting_rule.test_rule", "actions.0.alerts_filter.0.timeframe.#", "0"), |
There was a problem hiding this comment.
what's the .#? length of the array?
adcoelho
reviewed
Oct 30, 2024
internal/kibana/alerting_test.go
Outdated
Comment on lines
430
to
432
| timezone = "Africa/Accra" | ||
| hours_start = "01:00" | ||
| hours_end = "07:00" |
There was a problem hiding this comment.
nit: now it's misaligned with days 😅
adcoelho
previously approved these changes
Oct 30, 2024
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Nov 19, 2024
…tic#886) * Support alerting rules with only one of kql or timeframe fields * CHANGELOG.md * Fix tests * Fix alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #874
Ensure that KQL and Timeframe fields are only populated if they're actually set in the TF module.