Skip to content

Prepare unnamed reuse statements #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

greg-rychlewski
Copy link
Member

This continues the work of @hkrutzer in #126 and #92.

The idea is to cache the last prepared query in unnamed mode and reuse it when you can. To summarize:

For unnamed:

  • don't immediately close the query
  • close the last query on new prepare or execution of a different query

For named:

  • keep the same behaviour immediately closing queries with "" name (i.e. if they call query without specifying cache_statement).

@wojtekmach
Copy link
Member

@greg-rychlewski @hkrutzer thank you!

wojtekmach added a commit that referenced this pull request Jan 24, 2022
greg-rychlewski pushed a commit to greg-rychlewski/myxql that referenced this pull request Jan 24, 2022
@greg-rychlewski greg-rychlewski deleted the prepare-unnamed-reuse-statements branch April 11, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants