Add doc to define function in type module #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jul 3, 2024
Comment on lines
+20
to
+21
| - The type infos are associated to extensions using the `matching/1` callback | ||
| - The sub-oids for super extensions are created using the `oids/2` callback |
There was a problem hiding this comment.
Removing indentation otherwise it might be rendered as code:
Suggested change
| - The type infos are associated to extensions using the `matching/1` callback | |
| - The sub-oids for super extensions are created using the `oids/2` callback | |
| - The type infos are associated to extensions using the `matching/1` callback | |
| - The sub-oids for super extensions are created using the `oids/2` callback |
josevalim
reviewed
Jul 3, 2024
josevalim
reviewed
Jul 3, 2024
josevalim
approved these changes
Jul 3, 2024
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this might be helpful for new people who might be intimidated by the macros. Also it will help me when I come back to this module in a few years and can't remember what it does.