Add mix test --dry-run flag #14499
Open
Add mix test --dry-run flag #14499
+65
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nezteb
force-pushed
the
mix-test-dry-run-flag
branch
from
0eadca6 to
64bb5e1
Compare
Nezteb
commented
May 15, 2025
|
I'm not quite sure why one of the builds is failing: |
Nezteb
commented
May 15, 2025
Nezteb
commented
May 15, 2025
Nezteb
commented
May 15, 2025
| @@ -770,6 +770,40 @@ defmodule Mix.Tasks.TestTest do | |||
| end | |||
| end | |||
|
|
|||
| describe "--dry-run" do | |||
There was a problem hiding this comment.
More test cases to add:
-
--dry-run+--only -
--dry-run+--exclude - ...?
whatyouhide
reviewed
May 16, 2025
There was a problem hiding this comment.
So, implementation-wise I think we might need to take a different approach. Right now, I see two main issues:
- We're not running
ExUnit.Formatters on dry runs—I think we might want to. Basically, the only thing we want--dry-runto do is to literally skip executing the body of tests (+setup/setup_allcalls and whatnot), but everything else would be the same. - We are printing test files, but this doesn't give us information about what tests (or test cases even, if there are >1 test cases in a file) would run. I think this is important. Think of using
--dry-runto answer the question "if I pass this--excludeoption, how many tests will be skipped"?.
Do these points make sense? I am not even sure this is very feasible, so we'd need to sort of proof-of-concept this.
Nezteb
commented
May 16, 2025
Comment on lines
+50
to
+61
| modules_to_restore = | ||
| if not opts[:dry_run] do | ||
| do_run(config, modules_to_restore, opts, load_us) | ||
| else | ||
| nil | ||
| end | ||
|
|
||
| stats = ExUnit.RunnerStats.stats(stats_pid) | ||
| EM.stop(config.manager) | ||
| after_suite_callbacks = Application.fetch_env!(:ex_unit, :after_suite) | ||
| Enum.each(after_suite_callbacks, fn callback -> callback.(stats) end) | ||
| {stats, modules_to_restore} |
There was a problem hiding this comment.
@whatyouhide So, I tried to move the flag down the stack as far as possible. I still need to write tests, but does this look more in the right direction? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address #14393