Skip to content

More type checking of function applications #14508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions lib/elixir/lib/module/types/apply.ex
Original file line number Diff line number Diff line change
Expand Up @@ -472,19 +472,27 @@ defmodule Module.Types.Apply do
Returns the type of a remote capture.
"""
def remote_capture(modules, fun, arity, meta, stack, context) do
# TODO: We cannot return the unions of functions. Do we forbid this?
# Do we check it is always the same return type? Do we simply say it is a function?
if stack.mode == :traversal do
# TODO: Do we check when the union of functions is invalid?
# TODO: Deal with :infer types
if stack.mode == :traversal or modules == [] do
{dynamic(fun(arity)), context}
else
context =
Enum.reduce(
modules,
context,
&(signature(&1, fun, arity, meta, stack, &2) |> elem(1))
)
{type, fallback?, context} =
Enum.reduce(modules, {none(), false, context}, fn module, {type, fallback?, context} ->
case signature(module, fun, arity, meta, stack, context) do
{{:strong, _, clauses}, context} ->
{union(type, fun_from_non_overlapping_clauses(clauses)), fallback?, context}

{_, context} ->
{type, true, context}
end
end)

{dynamic(fun(arity)), context}
if fallback? do
{dynamic(fun(arity)), context}
else
{type, context}
end
end
end

Expand All @@ -496,10 +504,10 @@ defmodule Module.Types.Apply do

* `:none` - no typing information found.

* `{:infer, domain or nil, clauses}` - clauses from inferences. You must check all
all clauses and return the union between them. They are dynamic
and they can only be converted into arrows by computing the union
of all arguments.
* `{:infer, domain or nil, clauses}` - clauses from inferences.
You must check all clauses and return the union between them.
They are dynamic and they can only be converted into arrows by
computing the union of all arguments.

* `{:strong, domain or nil, clauses}` - clauses from signatures. So far
these are strong arrows with non-overlapping domains
Expand Down
Loading
Loading