Unresolved import problems

[floli]

Hello,

my Python LSP configuration is:

(use-package lsp-python-ms
  :ensure t
  :config (progn
            (setq lsp-python-ms-extra-paths '("/path_to_package/mypackage/src/")))
  :hook (python-mode . lsp))

Now I have a line in a python file that gives an unresolved import:

import mypackage.helper.glog as log

I validate that path above should fix the unresolved import by

$ unset PYTHONPATH 
$ python
Python 2.7.17 (default, Apr 15 2020, 17:20:14) 

>>> import mypackage.helper.glog as log
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named mypackage.helper.glog

>>> import sys
>>> sys.path.append("/path_to_package/mypackage/src/")

>>> import mypackage.helper.glog as log
>>> [no error message]

Still, Python LSP gives me an unresolved import 'mypackage'

Versions:

• GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.32) of 2020-05-07
• LSP as of today from MELPA

What can still be wrong at my setup?

Thanks!

[seagle0128]

lsp-python-ms-extra-paths is buffer-local. Can you check its value in buffer?

[floli]

Yes, it is set.

lsp-python-ms-extra-paths is a variable defined in ‘lsp-python-ms.el’.
Its value is
("/path_to_package/mypackage/src/")

[seagle0128]

Can you provide example files for troubleshootings?

[floli]

Sorry, just tried to reproduce on a vanilla example, but was unable to. It always worked as expected. However, at my original project it still fails.

I tried to delete my lsp-sessions and the ~/.emacs.d/.cache directory. LSP now asks to reinstall the server and fails with the same message I have described in the other issue.

Sorry, no helpful news. I keep trying and try to investigate.

[seagle0128]

Updating to the latest version will address the downloading issue.

[floli]

I think I am able to reproduce this issue. I have attached a simple python project:
mspyls.zip

mspyls <- git root there, so LSP asks to add this project root
    init.el <- I tested it with emacs -q --load init.el
    subdir/ <- that's important
    lib/hello.py
    src/main.py <- imported from lib import hello

it works (runs) when I set the PYTHONPATH and run python, but not when setting lsp-python-ms-extra-paths to the same value (unresolved import and no jumping to definition).

[seagle0128]

Please update to the latest and use this setting:

(setq-default lsp-python-ms-extra-paths '("/Users/vincent/Desktop/mspyls/subdir"))

[floli]

Hello,
unfortunately using lsp-python-ms-20200520.1609/ from elpa, I am still not successful. Updated config is:

(setq-default lsp-python-ms-extra-paths '("/lhome/lindnfl/scratch/mspyls/subdir"))
(use-package lsp-python-ms
  :ensure t
  :config (progn
            (setq-default lsp-python-ms-extra-paths
                  '("/lhome/lindnfl/scratch/mspyls/subdir")))
  :hook (python-mode . lsp))

I use setq-default twice to make sure it's set at the earliest occasion. Using my small example above, I still get the unresolved import.

[failable]

Same issue here. Although I use setq since lsp-python-ms-extra-paths is buffer local but using setq-default still no help. The variable is indeed passed into lsp-python-ms--extra-init-params but it is indeed not in :searchPaths of the returned value.

Setting PYTHONPATH does work, but is not that convenient.

[seagle0128]

@floli @Isolet Please check the value of (lsp--suggest-project-root). And set lsp-auto-guess-root to nil and retry. Or set the correct project root.

Remember to restart lsp server.

[failable]

Nothing changes. With lsp-auto-guess-root is nil or t, (lsp--suggest-project-root) return the right project root thought.

As I mentioned before,

The variable is indeed passed into lsp-python-ms--extra-init-params but it is indeed not in :searchPaths of the returned value.

[seagle0128]

It does work on my both laptops, with the sample project mspyls.zip.

[failable]

Yes, that works since lib has been packed into a module. However, if one puts a def hello_world in utils.py within the same directory of main.py, he just can neither import it in main.py nor jump to its definition. A project can contain modules, and example/script files which are not necessary to be a module.