Add allow_null serialization output note #5641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Dec 1, 2017
There was a problem hiding this comment.
Thanks @rpkilby.
I'm basically +1 here, since there's always a degree of confusion as to how these flags interact.
Bottom line is (I guess) it's just complicated but until such a time as we can re-work things/docs to be clearer more detail is better.
| @@ -45,6 +45,8 @@ Defaults to `True`. | |||
|
|
|||
| Normally an error will be raised if `None` is passed to a serializer field. Set this keyword argument to `True` if `None` should be considered a valid value. | |||
|
|
|||
| Note that setting this argument to `True` will imply a default value of `null` for serialization output, but does imply a default for input deserialization. | |||
There was a problem hiding this comment.
Hi,
shouldn't this:
but does imply a default for input deserialization.
be instead:
but does not imply a default for input deserialization.
Sorry for the noise if I'm wrong :)
There was a problem hiding this comment.
Yep - that's definitely a typo.
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #5639, although I'm indifferent to its inclusion.