Skip to content

Fix request formdata handling #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2018

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Feb 1, 2018

Pulling this out of #5771. This fixes a bug from #5590, where the request POST/FILES were also set for requests that did not have a form media type.

@rpkilby rpkilby added this to the 3.8 Release milestone Feb 1, 2018
@tomchristie
Copy link
Member

Looks reasonable.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Good stuff @rpkilby. Thanks!

@carltongibson carltongibson merged commit c456b3c into encode:master Feb 5, 2018
@rpkilby rpkilby deleted the fix-request-formdata branch February 5, 2018 15:52
hamishcampbell pushed a commit to koordinates/django-rest-framework that referenced this pull request Oct 9, 2018
* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
hamishcampbell pushed a commit to koordinates/django-rest-framework that referenced this pull request Oct 9, 2018
* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
craigds pushed a commit to koordinates/django-rest-framework that referenced this pull request May 26, 2019
Backport of c456b3c from 3.8.0

* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
craigds pushed a commit to koordinates/django-rest-framework that referenced this pull request May 26, 2019
Backport of c456b3c from 3.8.0

* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Rename 'wsgi' request test to more accurate 'http'

* Test duplicate request stream parsing

* Fix setting post/files on the underlying request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants