Added Deprecation Warnings for CoreAPI #7519

smithdc1 · 2020-09-04T21:31:53Z

Fixed #7007 -- CoreAPI deprecation not being raised

As per comments in the linked issue, this PR looks to add deprecation warnings for CoreAPI. Comments some time ago suggested this should form part of the 3.12 release.

I have:

Added warnings at where I think are the relevant points
Added a filter that suppresses all of these warnings from the existing test suite. This is based on a regex match of the warning message
Added deprecation tests to check that the warning is actually raised when those elements are used.

carltongibson · 2020-09-05T06:18:24Z

Super. Good work @smithdc1. Yes, it's time to add these I think. 👍

carltongibson

Looks good. (Half wonder if we need to trigger the warnings in the paginator, for example, but I can't see that it hurts.)

smithdc1 · 2020-10-10T17:41:25Z

As this is now targeting the 3.13 release I've moved the warnings to target removal in 3.15. I've also rebased.

tests/schemas/test_coreapi.py

johnthagen · 2020-10-27T23:37:58Z

@carltongibson As someone helping maintain drf-yasg, which is still using coreapi.SchemaGenerator, do you know about how long it will be before DRF 3.13 is released (i.e. how much time we have to migrate away before warnings are thrown)?

Thanks.

carltongibson · 2020-10-28T05:46:32Z

Hi @johnthagen. I'd say a while. 😀

This was to go in 3.12, but didn't make it. That's OK. I originally meant to add the warnings around the 3.10 timescale. But bandwidth as ever.

If I were you I'd pull the few CoreAPI bits out separately so that you're not relying on them being in DRF at all.

The whole idea of SchemaGenerator, and attaching via the descriptor at schema was to decouple the schema generation from the rest of the framework.

If you moved those bits you need wholesale, they'd no longer be an issue. (It should just be a couple of classes no? 🤔)

stale · 2022-03-25T01:33:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

auvipy · 2022-11-29T08:07:30Z

@tfranzel are you going to handle this one? if not I will try to fix the conflict

tfranzel · 2022-11-29T08:17:20Z

@auvipy I will have a look later today.

auvipy · 2022-12-02T13:50:25Z

I fixed the merge conflicts, might need to fix the lint errors as well, I want to know if removed in 3.15 is still right for this? or we should increment the version number?? If no I will check what else need to be adjusted to merge this over the next couple of weeks.

rest_framework/__init__.py

rest_framework/filters.py

tests/schemas/test_coreapi.py

rest_framework/filters.py

rest_framework/pagination.py

auvipy

merging this without the pre commit fixes. will fix them separately

* fix OpenAPIRenderer for timedelta * added test for rendering openapi with timedelta * fix OpenAPIRenderer for timedelta * added test for rendering openapi with timedelta * Removed usage of field.choices that triggered full table load (#8950) Removed the `{{ field.choices|yesno:",disabled" }}` block because this triggers the loading of full database table worth of objects just to determine whether the multi-select widget should be set as disabled or not. Since this "disabled" marking feature is not present in the normal select field, then I propose to remove it also from the multi-select. * Added Deprecation Warnings for CoreAPI (#7519) * Added Deprecation Warnings for CoreAPI * Bumped removal to DRF315 * Update rest_framework/__init__.py * Update rest_framework/filters.py * Update rest_framework/filters.py * Update tests/schemas/test_coreapi.py * Update rest_framework/filters.py * Update rest_framework/filters.py * Update tests/schemas/test_coreapi.py * Update tests/schemas/test_coreapi.py * Update setup.cfg * Update rest_framework/pagination.py --------- Co-authored-by: Asif Saif Uddin <[email protected]> * Update copy right timeline * Fix NamespaceVersioning ignoring DEFAULT_VERSION on non-None namespaces (#7278) * Fix the case where if the namespace is not None and there's no match, NamespaceVersioning always raises NotFound even if DEFAULT_VERSION is set or None is in ALLOWED_VERSIONS * Add test cases * fix OpenAPIRenderer for timedelta * added test for rendering openapi with timedelta * added testcase for rendering yaml with minvalidator for duration field (timedelta) --------- Co-authored-by: Rizwan Shaikh <[email protected]> Co-authored-by: Lenno Nagel <[email protected]> Co-authored-by: David Smith <[email protected]> Co-authored-by: Asif Saif Uddin <[email protected]> Co-authored-by: Konstantin Kuchkov <[email protected]>

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

smithdc1 force-pushed the coreapi branch 2 times, most recently from 322ef8c to 937e2d1 Compare September 4, 2020 22:01

carltongibson added this to the 3.12 Release milestone Sep 5, 2020

carltongibson approved these changes Sep 5, 2020

View reviewed changes

tomchristie modified the milestones: 3.12 Release, 3.13 Release Sep 28, 2020

smithdc1 added 2 commits October 10, 2020 18:32

Added Deprecation Warnings for CoreAPI

560e581

Bumped removal to DRF315

73f3e0a

smithdc1 force-pushed the coreapi branch from 937e2d1 to 73f3e0a Compare October 10, 2020 17:39

smithdc1 commented Oct 10, 2020

View reviewed changes

tests/schemas/test_coreapi.py Outdated Show resolved Hide resolved

johnthagen mentioned this pull request Oct 27, 2020

Migrate away from abandoned coreapi/coreschema dependency axnsan12/drf-yasg#389

Open

tomchristie modified the milestones: 3.13 Release, 3.14 Jan 10, 2022

stale bot added the stale label Mar 25, 2022

stale bot removed the stale label Nov 29, 2022

Merge branch 'master' into coreapi

3f68619

auvipy suggested changes Jun 12, 2023

View reviewed changes

auvipy added 2 commits June 12, 2023 12:37

Update rest_framework/__init__.py

b8cc5fe

Update rest_framework/filters.py

b47fee6

auvipy suggested changes Jun 12, 2023

View reviewed changes

rest_framework/filters.py Outdated Show resolved Hide resolved

auvipy added 2 commits June 12, 2023 12:39

Update rest_framework/filters.py

9079f48

Update tests/schemas/test_coreapi.py

e813139

auvipy added 10 commits June 12, 2023 12:44

Update rest_framework/schemas/coreapi.py

43f87cd

Update rest_framework/schemas/coreapi.py

3592a14

Update tests/schemas/test_coreapi.py

6631a09

Update setup.cfg

bc6d534

Update tests/schemas/test_coreapi.py

5ec8d3a

Update tests/schemas/test_coreapi.py

4045e06

Update tests/schemas/test_coreapi.py

4852e0d

Update tests/schemas/test_coreapi.py

c8f1d04

Update tests/schemas/test_coreapi.py

2c42919

Update tests/schemas/test_coreapi.py

34068c2

auvipy suggested changes Jun 12, 2023

View reviewed changes

rest_framework/pagination.py Outdated Show resolved Hide resolved

Update rest_framework/pagination.py

58bbe9b

auvipy self-assigned this Jun 12, 2023

auvipy approved these changes Jun 12, 2023

View reviewed changes

auvipy merged commit a16dbfd into encode:master Jun 13, 2023

auvipy added the Enhancement label Jun 13, 2023

smithdc1 deleted the coreapi branch November 26, 2023 22:11

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Oct 21, 2024

python3Packages.djangorestframework: remove coreapi dependency

49a8938

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Oct 21, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

027f042

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 9, 2024

python3Packages.djangorestframework: remove coreapi dependency

f662d8a

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 9, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

c73f98e

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework: remove coreapi dependency

76dd28c

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

1382746

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework: remove coreapi dependency

1cf8c23

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

6f141ba

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework: remove coreapi dependency

cee0be0

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

b88deeb

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework: remove coreapi dependency

d52b5e4

Using coreapi with this package is deprecated by upstream: encode/django-rest-framework#7519

tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Nov 22, 2024

python3Packages.djangorestframework-stubs: remove coreapi dependency

532244a

Using coreapi with the main package is deprecated by upstream: encode/django-rest-framework#7519

Uh oh!

Added Deprecation Warnings for CoreAPI #7519

Added Deprecation Warnings for CoreAPI #7519

Uh oh!

Conversation

smithdc1 commented Sep 4, 2020

Uh oh!

carltongibson commented Sep 5, 2020

Uh oh!

carltongibson left a comment

Choose a reason for hiding this comment

Uh oh!

smithdc1 commented Oct 10, 2020

Uh oh!

Uh oh!

johnthagen commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carltongibson commented Oct 28, 2020

Uh oh!

stale bot commented Mar 25, 2022

Uh oh!

auvipy commented Nov 29, 2022

Uh oh!

tfranzel commented Nov 29, 2022

Uh oh!

auvipy commented Dec 2, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnthagen commented Oct 27, 2020 •

edited

Loading