Solve Excel loading for xlrd/openpyxl/pandas issues #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matrix tested manually for xlrd in [1.2, 2.0] and for pandas in [0.25.2, 1.1.5]. Openpyxl is now a direct dependency due to exception capture.
|
This pull request introduces 1 alert when merging 5fb9b5c into b46f720 - view on LGTM.com new alerts:
|
cjw296
reviewed
Dec 14, 2020
| @@ -1044,6 +1055,46 @@ def filter_nan_from_dict(params): | |||
| return cleaned_params | |||
|
|
|||
|
|
|||
| def infer_tabular_file_format(filename): | |||
There was a problem hiding this comment.
You could also look at using the inference code from xlrd to make this more reliable and with less overhead:
https://xlrd.readthedocs.io/en/latest/api.html#xlrd.inspect_format
There was a problem hiding this comment.
Thanks for you support!
Pyscal must cater for xlrd==1.2.0 still for some time, where the inspect_format() is not available, so then I guess the trial-and-error approach is good for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrix tested manually for xlrd in [1.2, 2.0] and for pandas
in [0.25.2, 1.1.5].
Openpyxl is now a direct dependency due to exception capture.
Solves #221