Skip to content

prtvol2csv - Added warning for not initial report #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

lilbe66
Copy link
Contributor

@lilbe66 lilbe66 commented Jun 30, 2025

Added a warning if the volume report extracted is not from the initial date.
Also removed unused suffix in result file folder.

closes #710
closes #796

@lilbe66 lilbe66 force-pushed the prtvol2csv_warn_initial branch from c27aae9 to 1c1040e Compare July 2, 2025 07:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (b449cd5) to head (1c1040e).

Files with missing lines Patch % Lines
src/subscript/prtvol2csv/prtvol2csv.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   85.34%   85.38%   +0.04%     
==========================================
  Files          49       49              
  Lines        7518     7539      +21     
==========================================
+ Hits         6416     6437      +21     
  Misses       1102     1102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lilbe66 lilbe66 requested review from rnyb and mferrera July 2, 2025 07:38
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilbe66 lilbe66 merged commit f19cbac into equinor:main Jul 4, 2025
4 checks passed
@lilbe66 lilbe66 deleted the prtvol2csv_warn_initial branch July 4, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused suffix in prtvol2csv prtvol2csv Trigger a warning if the report is not from initial time
3 participants