Skip to content

fix: "SubsurfaceViewer: colorAbove/colorBelow/colorNaN possibly not working? #2479" #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2025

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented May 30, 2025

Added a few more properties to colormap layer.
See new stories under HillshadingLayer folder.
This will allow contour lines and hillshading directly in colormap layer.

Also added option to set clamp color. The previous behavior would clamp to colormap min and max value. This will give the option to clamp to a given fixed color. (or transparent)

New properties:

    // If true, draw contour lines.  Default false.
    contours: boolean;

    // If true, apply hillshading. Default false.
    hillshading: boolean;

    // Contour reference height. Default 0.
    contourReferencePoint: number;

    // Height between contour lines. Default 50.
    contourInterval: number;

    /**  Clamp colormap to this color at ends.
     * Given as array of three values (r,g,b) e.g: [255, 0, 0]
     * If not set or set to true, it will clamp to color map min and max values.
     * If set to false the clamp color will be completely transparent.
     */
    colorMapClampColor: Color | undefined | boolean;

    // Optional height map. If set hillshading and contourlines will be based on this map.
    heightMapUrl: string;

    // Min and max values of optional height map.
    // Defaults to "valueRange".
    heightValueRange: [number, number];

@nilscb nilscb self-assigned this May 30, 2025
@nilscb nilscb added enhancement New feature or request AspenTech Task owned by AspenTech labels May 30, 2025
@nilscb nilscb linked an issue May 30, 2025 that may be closed by this pull request
@nilscb nilscb force-pushed the ColorMapLayerImprovments branch 3 times, most recently from 28e269b to 836b259 Compare May 30, 2025 13:51
@nilscb nilscb force-pushed the ColorMapLayerImprovments branch from 836b259 to 085bfef Compare May 30, 2025 13:53
@nilscb nilscb requested a review from w1nklr June 2, 2025 09:10
@nilscb
Copy link
Collaborator Author

nilscb commented Jun 2, 2025

image

@nilscb nilscb merged commit 826e96d into equinor:master Jun 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SubsurfaceViewer: colorAbove/colorBelow/colorNaN possibly not working?
2 participants