fix: Multiple layers not including default shaderModules and layer.opacity not used in fragment shader

[rubenthoms]

Using super.getShaderModules({}) injects the default layer modules, e.g. layerUniforms which is required to access props.opacity in the fragment shader via layer.opacity.

References:

• https://github.com/visgl/deck.gl/blob/master/modules/core/src/shaderlib/misc/layer-uniforms.ts#L18
• https://github.com/visgl/deck.gl/blob/58c90974a70830cd1ca7d6d012822f75f5d40b17/modules/core/src/lib/layer-manager.ts#L93
• https://github.com/visgl/deck.gl/blob/58c90974a70830cd1ca7d6d012822f75f5d40b17/modules/core/src/lib/layer.ts#L454

Layers changed:

• Axes2D
• GridLayer3D
• Hillshading2D
• NorthArrow
• Map
• PieChart
• Colormap
• Triangle
• WellMarkers

[w1nklr]

Seems good to me.
Waiting for the upload for other layers, as discussed.

[w1nklr]

BTW, shouldn't the 2 last lines of cellProperty.vs.glsl.ts and nodeProperty.vs.glsl.ts be removed ?

   vec4 color = vec4(0.0);
   DECKGL_FILTER_COLOR(color, geometry);

This should not be part of a vertex shader, right ?

[rubenthoms]

BTW, shouldn't the 2 last lines of cellProperty.vs.glsl.ts and nodeProperty.vs.glsl.ts be removed ?

   vec4 color = vec4(0.0);
   DECKGL_FILTER_COLOR(color, geometry);

This should not be part of a vertex shader, right ?

Good question. This seems to apply a highlighting to entities. In deck.gl layers, this is also called within the vertex shader. So either we are doing it right or they are doing it wrong. I suggest we look at this later and not as part of this PR.

[w1nklr]

BTW, shouldn't the 2 last lines of cellProperty.vs.glsl.ts and nodeProperty.vs.glsl.ts be removed ?

   vec4 color = vec4(0.0);
   DECKGL_FILTER_COLOR(color, geometry);

This should not be part of a vertex shader, right ?

Good question. This seems to apply a highlighting to entities. In deck.gl layers, this is also called within the vertex shader. So either we are doing it right or they are doing it wrong. I suggest we look at this later and not as part of this PR.

I gave a look and understand better.
These DECKGL_FILTER_COLOR, be it in vertex or fragment shader, allow users of the layer to inject custom behavior.
In particular, this is used by deck.gl for picking !
This mean that DECKGL_FILTER_COLOR should be in (nearly) each and every shader file.

I counted 14 shader files without DECKGL_FILTER_COLOR.
We probably don't want to apply that on the 4 axes2D shaders (axis2d is not really meant to display data and should be eventually be implemented not as a layer).
For other shaders (like for the north arrow or piechart ?), it is not sure that we want to pick them.

In any case, all (most) of them should apply the layer.opacity.

Here is the list:

# should support layer.alpha and picking (thus DECKGL_FILTER_COLOR)
src/layers/axes/box.fs.glsl.ts
src/layers/axes/box.vs.glsl.ts
src/layers/gpglLayers/triangleLine.fs.glsl.ts
src/layers/gpglLayers/triangleLine.vs.glsl.ts
src/layers/grid3d/line.vs.glsl.ts
src/layers/map/line.vs.glsl.ts
src/layers/triangle/line.fs.glsl.ts
src/layers/triangle/line.vs.glsl.ts
# should support layer.alpha
# and probably also not picking (thus no DECKGL_FILTER_COLOR)
src/layers/northarrow/northarrow.fs.glsl.ts
src/layers/northarrow/northarrow.vs.glsl.ts
src/layers/piechart/piechart.fs.glsl.ts
src/layers/piechart/piechart.vs.glsl.ts
# should not support picking (thus no DECKGL_FILTER_COLOR)
# and probably no layer.alpha (should be considered like the distance ruler)
src/layers/axes2d/label.fs.glsl.ts
src/layers/axes2d/label.vs.glsl.ts
src/layers/axes2d/line.fs.glsl.ts
src/layers/axes2d/line.vs.glsl.ts
# utility, should not be changed at all
src/layers/shader_modules/decoder.fs.glsl.ts

Do you feel to handle that in this PR, or do you prefer to handle that appart ?