Skip to content

feat: unify exposed types naming to colormap #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

w1nklr
Copy link
Collaborator

@w1nklr w1nklr commented Jun 17, 2025

Both colormap and colorMap naming scheme are present, bringing some confusion.
Moving to single notation: colormap.

Exposed part: exported API types
Rename:

  • exposed types

Old types are exported as deprecated

Occurrence count, after and before the PR

colormap colorMap
Published Code (a) 618 results in 40 files
547 results in 38 files
143 results in 28 files
209 results in 33 files
Full Code (b) 767 results in 60 files
674 results in 57 files
267 results in 49 files
355 results in 54 files
Overall (c) 783 results in 66 files
692 results in 64 files
293 results in 58 files
381 results in 63 files

PR for #2581

@w1nklr w1nklr requested a review from nilscb June 17, 2025 08:32
@w1nklr w1nklr merged commit fe0d1f8 into equinor:master Jun 17, 2025
11 checks passed
@w1nklr w1nklr deleted the rename_types_colormap branch June 17, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants