Correct Map3D layer readout alignment #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadab-skhan
added
bug
Changed Icon Fix equinor#829
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 73.04% 73.04%
=======================================
Files 74 74
Lines 1781 1781
Branches 286 286
=======================================
Hits 1301 1301
Misses 460 460
Partials 20 20
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
hkfb
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Not sure if it's related, but I get this error when picking the map3D surface:
Uncaught TypeError: Invalid attempt to destructure non-iterable instance.
In order to be iterable, non-array objects must have a [Symbol.iterator]() method.
at _nonIterableRest (main.iframe.bundle.js:10130)
at _slicedToArray (main.iframe.bundle.js:10128)
at getMapProperty (main.iframe.bundle.js:10372)
at TerrainMapLayer.getPickingInfo (main.iframe.bundle.js:10356)
at getLayerPickingInfo (vendors-node_modules_deck_gl_aggregation-layers_dist_esm_index_js-node_modules_deck_gl_json_d-eadb95.iframe.bundle.js:14903)
at vendors-node_modules_deck_gl_aggregation-layers_dist_esm_index_js-node_modules_deck_gl_json_d-eadb95.iframe.bundle.js:14874
at Array.forEach (<anonymous>)
at processPickInfo (vendors-node_modules_deck_gl_aggregation-layers_dist_esm_index_js-node_modules_deck_gl_json_d-eadb95.iframe.bundle.js:14864)
at DeckPicker._pickClosestObject (vendors-node_modules_deck_gl_aggregation-layers_dist_esm_index_js-node_modules_deck_gl_json_d-eadb95.iframe.bundle.js:11992)
at DeckPicker.pickObject (vendors-node_modules_deck_gl_aggregation-layers_dist_esm_index_js-node_modules_deck_gl_json_d-eadb95.iframe.bundle.js:11822)
I didn't get this error, I have made a small change, maybe you can try again, and if this error still persists we will discuss. |
hkfb
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct Map3D layer readout alignment
Changed Icon
Fix #829