Skip to content

feat: Automatic zoom to fit data bounds #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 31, 2022

Conversation

shadab-skhan
Copy link
Contributor

Fix #689

@shadab-skhan shadab-skhan added enhancement New feature or request AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Mar 29, 2022
@shadab-skhan shadab-skhan requested a review from hkfb March 29, 2022 03:59
@shadab-skhan shadab-skhan self-assigned this Mar 29, 2022
@shadab-skhan shadab-skhan force-pushed the autozoom branch 2 times, most recently from 33fc188 to b248ed8 Compare March 29, 2022 04:29
@hkfb
Copy link
Collaborator

hkfb commented Mar 29, 2022

The failing check is maybe related to this issue: plotly/dash#1992

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #909 (dadf648) into master (ae5f2f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          74       74           
  Lines        1785     1785           
  Branches      288      288           
=======================================
  Hits         1301     1301           
  Misses        464      464           
  Partials       20       20           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avanti-em I guess we need to learn how to regenerate the reference screenshots :)

@hkfb hkfb requested a review from avanti-em March 29, 2022 14:01
@avanti-em
Copy link
Contributor

@avanti-em I guess we need to learn how to regenerate the reference screenshots :)

I think I should implement an automatic images update process (via a PR by some bot).
I will try to search about it.
For now I will update the new images

@avanti-em avanti-em requested a review from hkfb March 30, 2022 10:18
@avanti-em
Copy link
Contributor

Corresponding snapshots added in this PR

@shadab-skhan shadab-skhan requested a review from avanti-em March 30, 2022 11:37
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! But it doesn't seem to work on all layers.

@shadab-skhan shadab-skhan merged commit 6d02ebd into equinor:master Mar 31, 2022
@shadab-skhan shadab-skhan deleted the autozoom branch April 13, 2022 09:28
hkfb pushed a commit that referenced this pull request Apr 11, 2025
## [1.2.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.2.1) (2025-04-11)

### Bug Fixes

* bump @emerson-eps/color-tables from 0.4.85 to 0.4.92 in /typescript ([#2509](#2509)) ([54ea5e4](54ea5e4)), closes [#915](#915) [#911](#911) [#909](#909) [#905](#905) [#890](#890)
hkfb pushed a commit that referenced this pull request Apr 11, 2025
## [1.5.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.5.1) (2025-04-11)

### Bug Fixes

* bump @emerson-eps/color-tables from 0.4.85 to 0.4.92 in /typescript ([#2509](#2509)) ([54ea5e4](54ea5e4)), closes [#915](#915) [#911](#911) [#909](#909) [#905](#905) [#890](#890)
hkfb pushed a commit that referenced this pull request Apr 11, 2025
## [1.7.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.7.1) (2025-04-11)

### Bug Fixes

* bump @emerson-eps/color-tables from 0.4.85 to 0.4.92 in /typescript ([#2509](#2509)) ([54ea5e4](54ea5e4)), closes [#915](#915) [#911](#911) [#909](#909) [#905](#905) [#890](#890)
hkfb pushed a commit that referenced this pull request Apr 11, 2025
## [1.10.6](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.10.6) (2025-04-11)

### Bug Fixes

* bump @emerson-eps/color-tables from 0.4.85 to 0.4.92 in /typescript ([#2509](#2509)) ([54ea5e4](54ea5e4)), closes [#915](#915) [#911](#911) [#909](#909) [#905](#905) [#890](#890)
hkfb pushed a commit that referenced this pull request Apr 11, 2025
## [2.4.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@2.4.1) (2025-04-11)

### Bug Fixes

* bump @emerson-eps/color-tables from 0.4.85 to 0.4.92 in /typescript ([#2509](#2509)) ([54ea5e4](54ea5e4)), closes [#915](#915) [#911](#911) [#909](#909) [#905](#905) [#890](#890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

Automatic zoom to fit data bounds
4 participants