-
Notifications
You must be signed in to change notification settings - Fork 60
Fix parameter distribution heatmap #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dropnan after calculating correlation matrix to drop nan values resulting from undefined (comparing constants).
- update commetns - leaner function call
Should we wait until #60 is merged? |
anders-kiaer
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
HansKallekleiv
pushed a commit
that referenced
this pull request
Apr 22, 2025
* Merge latest from develop (#51) * Fix scale factor for Unit set to Fraction * Attempt to fix issue with containment plots failing to show up initially * Update encrypted contact information * Improve hover-information * Fix bug that removed legend text in containment plots * Fix bug with UNSMRY assuming an older csv format * Add ContainmentDataProvider wrapper class Intended to wrap an EnsembleTableProvider that reads containment summary files (either csv or arrow) * Add UnsmryDataProvider wrapper class Intended to wrap an EnsembleTableProvider that reads unsmry summary files (either csv or arrow) * Add validation to containment classes * Change summary file read order Arrow format is attempted first instead of csv * Change summary file read order Fix issue with unsmry option and missing files * Fix issue with legend when first real is not "0" * Fix bug with unsmry reset * Remove large csv file check * Remove unused file size function * Changes to adapt CO2Leakage for residual trapping maps visualization * Format changes * Solve minor issues * Solve typo * Fix issue in property_origin * Minor fixes * Rename MapGroup CO2_MASS * Add visualization menu with separate filters for each attribute * Formatting with mypy, pylint and black * Simplify MapThresholds class * Fix visualization threshold bug for plume maps * Add mean in tornado table VolumetricAnalysis (#1297) * Fix merge conflict after rebase * Fix issues related to missing polygon data * Fix black format issues * Fix another conflict from rebase * Fix another rebase conflict * Handle missing well picks and mypy errors * Remove surface cache file mode (#1298) * OS temp path for image server (#1302) * Add missing file handling for well picks * Enable usage without either maps or containment tables * CCS-194: Fix after change of units for co2 mass. (#34) * Tweak visualization filter * Add polygon provider Basically a copy of the provider for fault polygons. Renamed "fault polygon" to "polygon" and added a couple of TODOs * CCS-213: Handle plume_groups (#36) * CCS-213: Start using plume group from containment results. * CCS-213: Cont using plume group from containment results. * CCS-213: Fixes for plume groups. * CCS-213: Add plume groups to filter. * CCS-213: Some minor fixes. * CCS-213: Minor fix. * Some tests. * CCS-213: Join lines before/after merge when coloring by plume groups. * CCS-213: Some refactoring. * CCS-213: Fix combine plume group with none as mark. * CCS-213: Minor fix. * CCS-213: Remove some prints. * CCS-213: Use starting 0-values for unmerged wells. * CCS-213: Fix for multiple realization. * CCS-213: Fix case without plume groups. * CCS-213: Minor fix. * CCS-213: Fix black. * CCS-213: Some refactoring. * CCS-213: Minor change, remove temp code. * Combine time plots, add mean/P10/P90 option * Fix formatting * Fix missing issues with EnsemblePolygonProvider * Distinguish p10 and p90 from mean, turn select-all-realizations into button * Introduce new polygon provider in plugin * Fix black/lint/mypy errorss * CCS-213: Rename "?" to "undetermined" and fix warning messages (#38) * CCS-213: Fix warning message. * CCS-213: Rename ? to undetermined. * Fix issues found while testing * Minor fix in _get_menu_options() (#39) * Minor fix in _get_menu_options(). * New minor fix. * Minor change. (#40) * CCS-212: Renaming (#41) * CCS-212: Renaming, graph plots. * CCS-212: Renaming, map plots. * CCS-212: More renaming, map plots. * CCS-212: More renaming, map plots. * CCS-191: Add statistics plot (#44) * CCS-191: Start on statistics plot. * CCS-191: Minor change. * CCS-191: Use color and mark options. * CCS-191: Cont use color and mark options. * CCS-191: Cont using color and mark options. * CCS-191: Fix in label names. * CCS-191: Add default category plotted, single option. * CCS-191: Minor fig fixes. * CCS-191: Add hovering. * CCS-191: Fix some filtering. * CCS-191: Remove prints and comments. * CCS-191: Fill date options, use in plot. * CCS-191: Same fixes for date, and use in first plot. * CCS-191: Change some names, add titles. * CCS-191: Clean up. * CCS-191: Fix in set_date_option(). * Black * isort * CCS-191: Minor change. * CCS-212: Renaming, changing same labels, changing back gas_phase to sgas etc, add code for XMF2 (#45) * CCS-212: Use old file names for sgas etc maps. * CCS-212: Allow XMF2-files as default in addition to AMFG. Some changes to labels for 2D maps. * CCS-212: Some clean up. * CCS-212: Add SGSTR as option. * CCS-212: Remove prints. * Fix linting (#49) * Fix linting * Fix linting 2 * Fix linting 3 * Fix linting 4 * Fix linting 5 * Fix linting 6 * Fix linting 7 * Fix linting 8 * Develop master merged (#50) * Add mean in tornado table VolumetricAnalysis (#1297) * Remove surface cache file mode (#1298) * OS temp path for image server (#1302) * Update README.md with deprecation warning (#1303) * No Active Rfts error message (#1304) Co-authored-by: Øyvind Lind-Johansen <[email protected]> * Pandas 2 compatibility for RFT plotter (#1305) * Pandas 2 compability for RFT plotter * black * Remove use of `wcc.ColorScales` (#1306) * Fix FutureWarning - cast to dtype (#1309) * Pandas 2 compability for ParameterResponseCorrelation (#1310) * Add field outline and custom well picks colors to MapViewerFMU (#1311) * Replaced use of `DashSubsurfaceViewer` with `SubsurfaceViewer` (#1312) * Expose rft input files as arguments (#1313) * exposed rft input files as arguments * black version updated * pylint fixes * pylint fixes * more fixes --------- Co-authored-by: Øyvind Lind-Johansen <[email protected]> * Disable cache for statistical surfaces (#1314) * Add check for length of numpy array (#1316) * Fix ensemble colors in relperm (#1317) --------- Co-authored-by: FredrikNevjenNR <[email protected]> Co-authored-by: FredrikNevjenNR <[email protected]> Co-authored-by: Vegard Kvernelv <[email protected]> Co-authored-by: Jorge Sicacha <[email protected]> Co-authored-by: jorgesicachanr <[email protected]> Co-authored-by: vegardkv <[email protected]> * Manual new commit for changes in CCS-101. (#52) * CCS-192: Add box plot, plus CCS-249: Add zone/region/phase etc in title of plots (#53) * CCS-192: Start on new box plot. * CCS-192: Fix color order, and fix none as option for mark_by. * CCS-192: Add option to plot poitns. * CCS-192: Default false for show realization points. * CCS-192: Adjust layout, add default option. * CCS-192: Option for choosing probability plot vs box plot. * CCS-192: Minor change. * CCS-192: Minor fix. * CCS-192: Remove prints. * CCS-192: Minor fix. * CCS-192: Add custom hovering template for realization points. * CCS-192: Add info to plot titles. * CCS-192: Add info to time plots. * CCS-192: Minor fix. * Black * CCS-192: Improvements to box plot (#54) * CCS-192: Change options for plotting points. * CCS-192: Fix titles. * CCS-192: Try adding hoovering info. * CCS-192: Cont attempt hoovering info. * CCS-192: Change to using go.Box, more flexibility. * CCS-192: Fix hoovering for points. * CCS-192: Better hoovering info, placement. * CCS-192: Fix in hoovering info for realization points. * CCS-192: Visual improvements. * CCS-192: Change q1-q3 calc to numpy default, and fix whiskers calc. * CCS-192: Change default box, only single if >20 categories. * CCS-192: Remove prints, fix in q1 q3. * CCS-192: Minor fixes. * CCS-192: Remove prints, old code, new fix q1 q3. * CCS-192: Minor fix, and black. * CCS-192: Change order hoovering info. * CCS-192: Some fixes in box plot (#55) * CCS-192: Make sort by color possible. * CCS-192: Print p10, p90 in hoovering * CCS-192: Remove None option for points. * CCS-192: Some label changes. * CCS-266: Fix warning. (#56) * CCS-274: Remove default for actual volume csv file. (#57) * CCS-275: Add phase as option for "Color by" (#58) * CCS-275: Start adding color by phase as option. * CCS-275: Make correct filter boxes for color by phase. * CCS-275: Fixes for plots when using phase as color by. * CCS-275: Change colors for phase-split. * CCS-275: Clean up. * CCS-275: Black. * Isort. * mypy * CCS-275: Fix colors. * Define P10 as low, P90 as high in the time plot * Suggestion for solution to issue 248 (avoid reset) * Resolve rebase conflict * Refactor CO2Leakage Create separate functions for each callback for readability * Fix bug with time graph legend Legend of the time graph was not handled correctly when toggling items and changing settings * CCS-275: Change colors. (#61) * Adapt to receive only attributes that differ from the default setting (#63) * CCS-276: Redo line types, fixing bug (#64) * CCS-276: Try fix, and some debugging print. * CCS-276: Remove debug prints. * Fix black * Fix issues with legend persistence for box plot Box plot was using the same "LegendData" as bar plot, leading to odd behaviour. Also fixed default options for statistics and box plot * Change from polygon to polygons for default dir boundaries. (#62) * CCS-275: Bug fix. (#65) * Fix bug with box/statstics plot legend persist Most changes are refactoring the dict representing containment info into a class and how containment ui IDs are referenced. This simplified unifying the legend for bar and stats plot * Fix bug when re-visiting co2leakage * Update documentation * Adjust docstring * Attempt to fix bug legend issue With large data sets, it has been observed that the legend state was not always preserved for the box plot when changing settings. This fix attempts to resolve this by removing a unnecessary re-evaluation when the legend state changes. * Fix linting (#69) * Black * isort * mypy iteration 1. * Use _utils.enum_shim for StrEnum. * mypy iteratoin 2. * Pylint iteration 1. * Pylint iteration 2. * Pylint iteration 3. * Pylint iteration 4. --------- Co-authored-by: FredrikNevjenNR <[email protected]> Co-authored-by: FredrikNevjenNR <[email protected]> Co-authored-by: Vegard Kvernelv <[email protected]> Co-authored-by: Jorge Sicacha <[email protected]> Co-authored-by: jorgesicachanr <[email protected]> Co-authored-by: vegardkv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from undefined (comparing constants).