Skip to content

fix: order visitor keys for ExportSpecifier in source code order #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overlookmotel
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Change visitation order for ExportSpecifier to source code order.

What changes did you make? (Give an overview)

Visit local before exported.

export { local as exported };

Related Issues

Fixes #655.

Is there anything you'd like reviewers to focus on?

I've opened this PR before anyone's had time to look at issue #655. I hope that's not considered rude. I hope it might be useful for checking if this change would break any rules (I assume it won't).

@eslint-github-bot eslint-github-bot bot added the bug label Jun 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 6, 2025
Copy link

linux-foundation-easycla bot commented Jun 6, 2025

CLA Signed

  • ✅login: overlookmotel / (0abb19f)

The committers listed above are authorized under a signed CLA.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Jun 6, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit dbad7d8 into eslint:main Jun 6, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 6, 2025
@github-actions github-actions bot mentioned this pull request Jun 6, 2025
@overlookmotel
Copy link
Contributor Author

Thanks for merging so swiftly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Visitor keys for ExportSpecifier are not in source code order
3 participants